Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply overrides in FWTW #90

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Apply overrides in FWTW #90

merged 9 commits into from
Oct 1, 2024

Conversation

liuly12
Copy link
Collaborator

@liuly12 liuly12 commented Mar 16, 2024

initial_storage is currently not enabled

@liuly12 liuly12 linked an issue Mar 16, 2024 that may be closed by this pull request
FWTW overrides #89
Closed
@liuly12 liuly12 self-assigned this Mar 16, 2024
barneydobson
barneydobson approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@barneydobson barneydobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some basic suggestions for tests - otherwise happy

tests/test_wtw.py Show resolved Hide resolved
tests/test_wtw.py Outdated Show resolved Hide resolved
tests/test_wtw.py Outdated Show resolved Hide resolved
liuly12 and others added 3 commits March 18, 2024 21:15
@liuly12 @barneydobson
check it doesn't delete other bits
e950f3d 
Co-authored-by: barneydobson <barnaby.dobson1@gmail.com>
@liuly12 @barneydobson
use something that itsn't the default value
ef70916 
Co-authored-by: barneydobson <barnaby.dobson1@gmail.com>
@liuly12 @barneydobson
use something that itsn't the default value
f7a21d6 
Co-authored-by: barneydobson <barnaby.dobson1@gmail.com>
@liuly12 liuly12 requested a review from dalonsoa April 10, 2024 09:13
dalonsoa
dalonsoa approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@dalonsoa dalonsoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now that tests and QA pass :)

@barneydobson barneydobson marked this pull request as ready for review October 1, 2024 12:06
@barneydobson barneydobson merged commit 1bad6b4 into main Oct 1, 2024
21 checks passed
@barneydobson barneydobson deleted the fwtw-overrides branch October 1, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneydobson barneydobson barneydobson approved these changes

@dalonsoa dalonsoa dalonsoa approved these changes

Assignees

@liuly12 liuly12

Labels
overrides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FWTW overrides
3 participants
@liuly12 @dalonsoa @barneydobson