Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added CI to build and push docker image #3 #5

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

khushalmer03
Copy link

@khushalmer03 khushalmer03 commented May 31, 2023

Fixes Issue

Closes #3 #4

Changes proposed

  • Build and push docker image to improwised/php-base from branch php82

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Note to reviewer

@deltasquare4 Please add docker credentials in secrets and variables -> actions -> DOCKER_USERNAME and DOCKER_PASSWORD

@khushalmer03 khushalmer03 self-assigned this May 31, 2023
@khushalmer03 khushalmer03 changed the base branch from master to php82 May 31, 2023 13:53
Copy link
Member

@deltasquare4 deltasquare4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khushalmer03 You should be able to set the secrets yourself now. LGTM.

@khushalmer03
Copy link
Author

@khushalmer03 You should be able to set the secrets yourself now. LGTM.

I still don't have rights to add secrets, only someone with admin rights can do it?

@deltasquare4
Copy link
Member

@khushalmer03 You should be able to set the secrets yourself now. LGTM.

I still don't have rights to add secrets, only someone with admin rights can do it?

Now you do.

@khushalmer03 khushalmer03 merged commit 89ab107 into php82 Jun 1, 2023
@munir131 munir131 deleted the feat/add-docker-CI branch June 1, 2023 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Construct a CI pipeline for docker-php-base repo.
3 participants