throw all exceptions out in ColumnarSQLRewriter #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -507,6 +507,7 @@ public void buildQuery() { | |||
| analyzeInternal(); | |||
| } catch (SemanticException e) { | |||
There was a problem hiding this comment.
We should throw the exception out, instead of catching and returning
| @@ -669,6 +665,8 @@ public synchronized String rewrite(Configuration conf, String query) | |||
| } | |||
| } catch (ParseException e) { | |||
| e.printStackTrace(); | |||
| } catch (SemanticException e) { | |||
There was a problem hiding this comment.
Should be thrown all the way up. No catching anywhere. If signature expects GrillException, then catch and throw with cause as this.
Amareshwari
changed the title
Amareshwari
added a commit
that referenced
this pull request
Oct 6, 2014
throw all exceptions out in ColumnarSQLRewriter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For queries having subqueries in from clause catch SemanticException and return.