Add missing tests for issuance modules #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janndriessen
commented
Mar 13, 2023
janndriessen
commented
- Adds tests for all active indices to return correct issuance modules based on index.
- Restructures test to make processing easier and quicker
| describe('getIssuanceModule() - Mainnet', () => { | ||
| test('returns basic issuance module for any other index', async () => { | ||
| const expectedAddress = BasicIssuanceModuleAddress | ||
| describe('getIssuanceModule() - Mainnet - IndexProtocol', () => { |
There was a problem hiding this comment.
I don't love this naming convention but I think the alternative is a lot more nesting of describe blocks which is the greater evil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.