Add component quotes provider #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
janndriessen
commented
Dec 28, 2022
•
janndriessen
commented
- Adds component quotes provider
- Fixes issues with FlashMintZeroEx quotes e.g. when there is only one component and it is equal to the input/output token
- Docs: indicate deprecated tokens
janndriessen
commented
Dec 28, 2022
|
|
||
| components.forEach((component, index) => { | ||
| const buyAmount = positions[index] | ||
| const sellAmount = positions[index] |
There was a problem hiding this comment.
I was thinking, here I should just be able to do something like amount = positions[index] right? Because it's always the same no matter if buy/sell?
janndriessen
commented
Dec 28, 2022
| if (buyToken === sellToken) { | ||
| const amount = isMinting ? buyAmount : sellAmount | ||
| const emptyResponse = this.getFakeZeroExResponse(amount) | ||
| quotePromises.push(emptyResponse) |
There was a problem hiding this comment.
My solution was to create this fake response which made the processing of results way easier and more flexible with different amounts of components.
janndriessen
commented
Dec 28, 2022
| * component and input/output token are the same. | ||
| */ | ||
| async getFakeZeroExResponse(amount: BigNumber): Promise<any> { | ||
| return Promise.resolve({ buyAmount: amount, data: '', sellAmount: amount }) |
There was a problem hiding this comment.
Would it be ok to just pass an empty string for componentQuotes? @ckoopmann
Or should I rather add something like 0x0?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.