Update code for compatibility with PHP8 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function overloading by mbstring has been removed.
The query was getting columns for the entity from both the warehouse schema and the information_schema. In pg13 a 'name' datatype is used rather than varchar for system info which is an unlisted sql_type. Rather than add that type, maybe we were processing data we didn't need so the information_schema columns are filtered out. This may prove to be a mistake!
With PHP 7.3, if $result is false, pg_fetch_array returns null. $result is expected to be false for tables that have no serial column. With PHP 8.0, a TypeError exception is raised.
DbUnit is being updated and now supports PHP8 but this has not been released on packagist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366