-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux in travis #23
linux in travis #23
Conversation
Thanks for your help in trying to get this issue resolved! Looks like the build is still failing though. Last week, I tried all permutations and combinations of the |
before installing the gsl R package. Related to https://github.com/cran/gsl/blob/master/INSTALL and to https://stackoverflow.com/questions/49162670/r-package-build-failing-on-unix-machines-due-to-missing-gsl-gnu-scientific-lib/49165163#49165163
I agree. I still think the gsl Linux package needs to be install (through apt) before attempting to install the gsl R package. This second commit includes it. The first one was a baseline. I'm surprised it's taking so long. I guess it's because your package has a lot of dependencies, which have a lot of dependencies, which have a lot of ... . And many of the packages are the intense kind, that require Linux building it from scratch. Maybe some of this could be optimized by installing different ways, or maybe using a specialized docker image (so the packages don't have to be build by Travis for every push). Anyway, I thought the gsl installation should be the first step, before worrying about the optimization. Are there any R packages that you could remove from your dependencies (especially those that require gsl)? |
Yeah, it's something I've been wondering myself. Irrespective of what happens with the Travis build, I'll work on minimizing the number of dependencies in the next few weeks. Will need a lot more coding to remove reliance on other packages, but should be possible. |
"These installs will be faster than source installs, but may not always be the most recent version" https://docs.travis-ci.com/user/languages/r/#Additional-Dependency-Fields
with `r-cran-qqq`. Also needs sudo. > "Specify the name just as you would when installing from CRAN. On OS X builds and builds without sudo: required, these packages are installed from source." https://docs.travis-ci.com/user/languages/r/#Additional-Dependency-Fields
Yea, it got to the gsl installation step without timing out, and it was successful. |
I bet the order isn't exactly right though.
That's awesome! I pushed few changes now that have removed two package dependencies, but there are still many heavy (mostly statistical) packages in there. Offloading them will need more time. |
it apparently isn't available
so it won't install from other R packages from source, before their binaries can be installed. Remove OpenMX b/c it was failing on the OSX builds
to keep the dependency calculations simpler. Something's getting tripped up with OpenMX
I don't know why Travis is looking for [these packages](https://travis-ci.org/IndrajeetPatil/ggstatsplot/jobs/353142095#L1620). It's not exactly the same list. ``` # - rpf # - openssl # - rlang # - igraph # - utf8 # - gss # - haven # - XML # - data.table # - matrixStats # - rgl # - dplyr # - purrr # - tidyver # - readr # - minqa # - mvtnorm # - SparseM # - lme4 # - httpuv # - markdown # - sem # - readxl # - openxlsx # - pander # - minpack.lm # - StanHeaders ```
It's installing correctly and within 10 minutes (but I expect that would increase during the peak times). Moving the This was good for me. I've wanted to experiment this on my own packages, but hadn't quite hit the threshold to motivate the research. Thanks for the SO bounty too. |
Thank you so so much!!! This was my first pull request EVER and I am so grateful to see that |
@IndrajeetPatil, no problem.I just saw that you're from psych too. Good luck with your package. |
@wibeasley Needed your help again. I haven't changed the Travis |
Line 5284. It looks like things s running a tad slower than before, and crossed the time or threshold:
Anything else you child trim or optimize for the dependencies? |
@wibeasley Sorry, this was a false alarm. I think Travis server was handling a lot of jobs and that's why it timed out. This hasn't happened again. |
@wibeasley Can we please try this again? I am again getting errors with the Travis build that I haven't been able to get rid of: I rewrote some code and removed three heavy dependencies in a new release and changed the |
https://docs.travis-ci.com/user/multi-os/#Example-Multi-OS-Build-Matrix
@IndrajeetPatil, I'm trying a few things in response to https://stackoverflow.com/a/49165163/1082435. I'm curious was Travis will do. Don't accept the PR for a while.