Filter fix for Nova Flexible Content #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelacey
requested review from
Krato and
InfinetyEs
and removed request for
Krato
Switch to passing predefined filters via query param instead of attempting to pull them off of the field in the backend at runtime.
stevelacey
force-pushed
the
nova-flexible-content-filters-fix
branch
from
c72be6c
to
07e169e
Compare
stevelacey
changed the title
Merged
|
Is working. I will merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to passing the
->filterBy()value via a query param to thegetDatacall instead of attempting to pull it off of the field via the backend Nova API at runtime.This makes the filterBy option work with packages that add support for nested fields e.g. Nova Flexible Content.
#116