misc UX improvements #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Send a more useful error message back instead of some lengthy EPPlus stack trace.
One common problem is forgetting to close the results xlsx file between runs, which throws errors trying to write after a potentially long comparison step. Catch that error and pick a different file name.
Relies on the default exception text, which might not be a safe assumption.
less linq, less string parsing. Should be more reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stop relying on specific exception messages
less linq, less string parsing. Should be more reliable
improve error message for duplicate column headers
Relies on the default exception text, which might not be a safe assumption.
hide some unhelpful logs
handle errors when the results file is open
One common problem is forgetting to close the results xlsx file between runs, which throws errors trying to write after a potentially long comparison step.
Catch that error and pick a different file name.
throw errors if we're not processing xlsx
Send a more useful error message back instead of some lengthy EPPlus stack trace.