Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev base classes #35

Merged
merged 10 commits into from
Nov 26, 2020
Merged

Conversation

wonch002
Copy link
Contributor

@wonch002 wonch002 commented Nov 3, 2020

No description provided.

@wonch002
Copy link
Contributor Author

wonch002 commented Nov 3, 2020

Please let me know if you would like me to add the example Add-Ons that I have for these classes, or if you would like me to make a seperate PR into master if/when this PR is approved.

@darren-wrigley

@wonch002
Copy link
Contributor Author

wonch002 commented Nov 4, 2020

I ended up adding my examples of using these classes to generate useful results. That can be seen in EDCTools.py. For examples on using the methods in EDCTools.py, checkout examples/examples.py

@darren-wrigley
Copy link
Collaborator

apologies for the delay - i am working through a few small tests on your contribution - thx!
one thing i probably need to add - is adding verify=False to the session +a line to disable warnings - so https connections will work, i tried that with a self signed site & also need to test with a https catalog using a proper certificate

@wonch002
Copy link
Contributor Author

@darren-wrigley That sounds good! I went ahead and set the verify attribute to False and updated the PR. Let me know if there are any other issues.

@darren-wrigley darren-wrigley merged commit c97beb7 into Informatica-EIC:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants