Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to set height and port from magic line command #11

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Allow user to set height and port from magic line command #11

merged 2 commits into from
Jul 4, 2023

Conversation

milochen0418
Copy link
Contributor

@milochen0418 milochen0418 commented Jul 3, 2023 •
edited
Loading

We can use the following magic line command to set up the height of the cell, and so do the port.

%xterm height=300 port=10001

The following YouTube shows how it works (Select 1440p)
https://www.youtube.com/watch?v=0eRO0xNzJ-s

This PR is also related to this issue

@milochen0418 milochen0418 mentioned this pull request Jul 3, 2023
Closed
popcornylu
popcornylu reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Some minor adjustments need to be made.

colabxterm/notebook.py Outdated Show resolved Hide resolved
colabxterm/notebook.py Outdated Show resolved Hide resolved
colabxterm/notebook.py Outdated Show resolved Hide resolved
colabxterm/notebook.py Outdated Show resolved Hide resolved
@milochen0418
Copy link
Contributor Author

Thanks for your PR. Some minor adjustments need to be made.

@popcornylu
Thanks for your excellent suggestion and your help.
I already improved it in the latest commit.
Please review it again.

popcornylu
popcornylu approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@popcornylu popcornylu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@popcornylu popcornylu merged commit 8e68131 into InfuseAI:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popcornylu popcornylu popcornylu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milochen0418 @popcornylu