Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update static report schema #916

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

wcchang1115
Copy link
Contributor

@wcchang1115 wcchang1115 commented Oct 25, 2023

PR checklist

  • Ensure you have added or ran the appropriate tests for your PR.
  • DCO signed

What type of PR is this?
bug

What this PR does / why we need it:

  • after v0.34.0, git_branch information in a run report could be null when compared with git references other than branches.

Which issue(s) this PR fixes:
sc-32458

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #916 (9a170d9) into main (04e6a2e) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #916   +/-   ##
=======================================
  Coverage   47.99%   48.00%           
=======================================
  Files          78       78           
  Lines       10756    10756           
=======================================
+ Hits         5162     5163    +1     
+ Misses       5594     5593    -1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Wei-Chun, Chang <wcchang@infuseai.io>
@wcchang1115 wcchang1115 marked this pull request as ready for review October 25, 2023 04:23
@wcchang1115 wcchang1115 merged commit 6b1c0a8 into main Oct 26, 2023
30 checks passed
@wcchang1115 wcchang1115 deleted the bug/sc-32458/update-run-report-schema-static-report branch October 26, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants