Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Update static report schema #916

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[Bug] Update static report schema #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46cda2
Update static report schema
wcchang1115 Oct 25, 2023
9a170d9
Update git branch type and nullable handler
wcchang1115 Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion static_report/src/components/Reports/ReportContextBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function ReportContextBar({
}: Props) {
let datasource: string | undefined = undefined;
let version: string | undefined = undefined;
let gitBranch: string | undefined = undefined;
let gitBranch: string | null | undefined = undefined;
let githubPr: string | undefined = undefined;
let githubPrUrl: string | undefined = undefined;
let baseFrom: string | undefined = undefined;
Expand Down Expand Up @@ -58,6 +58,8 @@ export function ReportContextBar({
report.input?.datasource.git_branch
) {
gitBranch = `${report.base?.datasource.git_branch} ↔ ${report.input?.datasource.git_branch}`;
} else if (report.input?.datasource.git_branch) {
gitBranch = report.input?.datasource.git_branch;
}

if (report.metadata?.github_pr_id && report.metadata?.github_pr_url) {
Expand Down
2 changes: 1 addition & 1 deletion static_report/src/sdlc/single-report-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ export interface AssertionTest {
export interface DataSource {
name: string;
type: string;
git_branch?: string;
git_branch?: string | null;
git_sha?: string;
skip_datasource?: boolean;
}
Expand Down
Loading