Skip to content

Commit

Permalink
Merge pull request #916 from InfuseAI/bug/sc-32458/update-run-report-…
Browse files Browse the repository at this point in the history
…schema-static-report

[Bug] Update static report schema
  • Loading branch information
wcchang1115 authored Oct 26, 2023
2 parents 04e6a2e + 9a170d9 commit 6b1c0a8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion static_report/src/components/Reports/ReportContextBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function ReportContextBar({
}: Props) {
let datasource: string | undefined = undefined;
let version: string | undefined = undefined;
let gitBranch: string | undefined = undefined;
let gitBranch: string | null | undefined = undefined;
let githubPr: string | undefined = undefined;
let githubPrUrl: string | undefined = undefined;
let baseFrom: string | undefined = undefined;
Expand Down Expand Up @@ -58,6 +58,8 @@ export function ReportContextBar({
report.input?.datasource.git_branch
) {
gitBranch = `${report.base?.datasource.git_branch}${report.input?.datasource.git_branch}`;
} else if (report.input?.datasource.git_branch) {
gitBranch = report.input?.datasource.git_branch;
}

if (report.metadata?.github_pr_id && report.metadata?.github_pr_url) {
Expand Down
2 changes: 1 addition & 1 deletion static_report/src/sdlc/single-report-schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ export interface AssertionTest {
export interface DataSource {
name: string;
type: string;
git_branch?: string;
git_branch?: string | null;
git_sha?: string;
skip_datasource?: boolean;
}
Expand Down

0 comments on commit 6b1c0a8

Please sign in to comment.