Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the Dockerfile to make it follow FHS conventions and fixing #60 bug #77

Merged
merged 3 commits into from
Mar 9, 2016

Conversation

ShibaOnTheMoon
Copy link
Contributor

Copying a binary file inside the /etc folder isn't a good idea. Furthermore, it prevents the use of a volume directly on the folder /etc/dockerbeat.

Only minor changes of the Dockerfile are necessary.

You can find more about the FHS specs here : http://refspecs.linuxfoundation.org/FHS_3.0/fhs/index.html


I've also fixed the the #60 issue (I wanted to create 2 distincts pull requests, but I've made a nistake while pushing my local work... sorry !)

@codecov-io
Copy link

Current coverage is 70.57%

Merging #77 into develop will increase coverage by +0.81% as of 41a1ff0

@@            develop     #77   diff @@
=======================================
  Files             7       7       
  Stmts           420     384    -36
  Branches         25      25       
  Methods           0       0       
=======================================
- Hit             293     271    -22
  Partial           4       4       
+ Missed          123     109    -14

Review entire Coverage Diff as of 41a1ff0

Powered by Codecov. Updated on successful CI builds.

@erwanncloarec
Copy link
Contributor

Thanks, it LGTM.

@ShibaOnTheMoon ShibaOnTheMoon changed the title Modified the Dockerfile to make it follow FHS convenctions Modified the Dockerfile to make it follow FHS convenctions and fixing #60 bug Mar 8, 2016
@ShibaOnTheMoon ShibaOnTheMoon changed the title Modified the Dockerfile to make it follow FHS convenctions and fixing #60 bug Modified the Dockerfile to make it follow FHS conventions and fixing #60 bug Mar 8, 2016
@marminthibaut marminthibaut self-assigned this Mar 9, 2016
marminthibaut added a commit that referenced this pull request Mar 9, 2016
@marminthibaut marminthibaut merged commit 5981dd1 into Ingensi:develop Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants