forked from stepfunc/rodbus
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Improvement of the Custom Function Code Feature (CFC) #6
Merged
grewek
merged 59 commits into
Iniationware:feature/custom-fc
from
dkoehler-dev:feature-cfc-improvements
Apr 3, 2024
Merged
Feat: Improvement of the Custom Function Code Feature (CFC) #6
grewek
merged 59 commits into
Iniationware:feature/custom-fc
from
dkoehler-dev:feature-cfc-improvements
Apr 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…niationware/rodbus)
…9 (CustomFC) tests
…I using changing CFC data
…port variable-length data
… the CFC69 CustomFC request to support variable-length data
…FC number for each CFC request
…e CustomFunctionCode trait
…ount in and out parameter
…tests to the new logic
I've updated the code with some additional improvements. In particular, the PR include now:
Let me know if you got any question or anything to add. These improvements were made by Dominik Köhler in the name of Iniationware GmbH and initialized by Klaus Landsdorf. Dominik Köhler, Freelancer @Iniationware |
biancode
changed the title
Feat: Improvement of the Custom Function Code Feature CFC69
Feat: Improvement of the Custom Function Code Feature (CFC)
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the existing Custom Function Code CFC69 implementation. In particular, it includes:
The Client and Server now include these improvements. The code changes were tested with the extended CFC69 unit tests and the existing integration test and should work as expected. Please let me know if you have any issues or questions when reviewing the code.
These improvements were made by Dominik Köhler in the name of Iniationware GmbH and initialized by Klaus Landsdorf.
Dominik Köhler, Freelancer @Iniationware