Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Improvement of the Custom Function Code Feature (CFC) #6

Merged

Conversation

dkoehler-dev
Copy link
Collaborator

This pull request improves the existing Custom Function Code CFC69 implementation. In particular, it includes:

  • Renaming from "WriteCustomFunctionCode" to "SendCustomFunctionCode"
  • An updated documentation of the CFC69 request (SCFC_README.md)
  • A custom client & server example to test the CFC69 request separate from the standard function codes (examples/custom_client.rs & examples/custom_server.rs)
  • Support for a variable length of CFC input arguments
  • Improved unit test cases

The Client and Server now include these improvements. The code changes were tested with the extended CFC69 unit tests and the existing integration test and should work as expected. Please let me know if you have any issues or questions when reviewing the code.

These improvements were made by Dominik Köhler in the name of Iniationware GmbH and initialized by Klaus Landsdorf.

Dominik Köhler, Freelancer @Iniationware

… the CFC69 CustomFC request to support variable-length data
@grewek grewek changed the base branch from development to feature/custom-fc February 19, 2024 12:32
@grewek grewek self-assigned this Feb 19, 2024
@dkoehler-dev
Copy link
Collaborator Author

I've updated the code with some additional improvements. In particular, the PR include now:

  • Support for dynamically handling all CFC requests (65-72 & 100-110), given they are implemented by the server
  • An updated version of the CFC request documentation
  • Updated unit tests and integration test
  • An updated CFC request, including the 'byte_count_in' and 'byte_count_out' fields to dynamically parse the request
  • Serial test case bugfix

Let me know if you got any question or anything to add.

These improvements were made by Dominik Köhler in the name of Iniationware GmbH and initialized by Klaus Landsdorf.

Dominik Köhler, Freelancer @Iniationware

…ction codes when sending a CFC request"

This reverts commit afbfbca.
@biancode biancode changed the title Feat: Improvement of the Custom Function Code Feature CFC69 Feat: Improvement of the Custom Function Code Feature (CFC) Apr 3, 2024
@grewek grewek merged commit 747712f into Iniationware:feature/custom-fc Apr 3, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants