Cleanup #102
Merged
Cleanup #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
albertchon
reviewed
Jan 5, 2024
| tokenPriceInUSDDec := decimal.NewFromFloat(tokenPriceInUSD) | ||
| totalFeeInUSDDec := decimal.NewFromBigInt(totalFees.BigInt(), -18).Mul(tokenPriceInUSDDec) | ||
| minFeeInUSDDec := decimal.NewFromFloat(r.minBatchFee) | ||
| totalFeeInUSDDec := decimal.NewFromBigInt(fees.BigInt(), -18).Mul(tokenPriceInUSDDec) |
There was a problem hiding this comment.
We can obtain the actual accurate decimals from the alchemy API (for tokens that are supported by their API) and/or fallback to querying the actual ERC-20 decimals function to obtain the accurate number of decimals
albertchon
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist:
.envfile usage:PEGGO_COSMOS_GRPCandPEGGO_TENDERMINT_RPCdo not have default values anymore. Omitting these 2 fields from the .env file will have peggo create a load-balanced connection to one of known Injective networks (based on the value ofPEGGO_COSMOS_CHAIN_ID). This change was enforced in the newersdk-goversion as default behaviour. If these 2 values are provided, peggo will connect to the custom RPC node.ethBlockConfirmationDelay = 96: previously set to 12 (release-prod/release-staging) but increased for security reasons due to Ethereum switching to PoS from PoW. This will affect ethereum->injective UX as it incurs a delay in observing Eth events