Image tag policy #105
Merged
Image tag policy #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need read/convert, not pick/store. * Only call the convert end point when CONVERT_OPTIONS are present. * Don't mutate @url, just use functions.
* Rails.application.config.filepicker_rails.policy_proc will be called to sign the URL. * Defaults to read/convert.
This reverts commit b1dd6f5. Conflicts: spec/rails_helper.rb
|
Looks good, @maurogeorge! |
|
Thanks a lot @mhoran @dannysullivan ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
Related to #95 #104
@mhoran @dannysullivan can you guys take a look ❤️ ? The argument for
expiry, need to be a callable, I added this here.I open this PR, to make easy to see the changes. If it is ok to you guys I will merge 😄