Filepicker field tag & multi_json to json #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add shared example spec to test filepicker_field and filepicker_field_tag
….2 specs to reliably pass
|
Changes Unknown when pulling cda5882 on daniel-bryant:filepicker_field_tag into * on Ink:master*. |
|
Thanks ! |
|
@daniel-bryant thanks for your PR! |
maurogeorge
added a commit
that referenced
this pull request
May 6, 2015
Filepicker field tag & multi_json to json
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a
filepicker_field_taghelper method as requested here. This method creates a valid filepicker input tag outside of aform_forblock. This allows for more flexibility, similar to having the choice between usingf.text_fieldortext_field_tag.The second commit addresses
multi_json's removal from Rails 4. Also see the Rails Guides. This issue was also causing my build to fail, as the gem versions installed by Travis CI were very different from the last master build and missingmulti_json.