changing helper to fix issue with filepicker_save_link #146
Conversation
| options[:data]['fp-mimetype'] = mimetype | ||
| options[:data]['fp-option-container'] = container if container | ||
| options[:data]['fp-option-services'] = Array(services).join(",") if services | ||
| options[:data]['fp-option-defaultSaveasName'] = save_as if save_as |
There was a problem hiding this comment.
I took a look at the documentation and yes these fp-option does not exist.
I can't find the suggestedFilename in the documentation. But we can continue on it, changing this option.
|
Hi @amione thanks for the PR. Could you please update the specs too to make all 🍏 . Thanks |
|
Yup, I will do that. I will get the suggested filename added to our docs
|
|
@maurogeorge I updated the tests and it looks like they passed, but there are some build failures that seem unrelated to any changes that I made. Any ideas about what is happening? |
|
Sorry @amione I am out from open source for a while. Unfortunately I cannot work on this to try reproduce the erros. |
I was working with a customer who was having trouble getting filepicker_save_link to work.
The gem was rendering the export tag with the following fields:
data-fp-option-services="BOX" and data-fp-option-defaultsaveasname="exampleName"
These needed to be data-fp-services and data-fp-suggestedFilename.
I found that they appeared to be wrong in the export widget method of the helper, and suggested the customer change them. He updated the helper himself and that fixed his issue, so I am issuing a pull request to update the helper.