Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese character does not show up #149

Open
johntheocs opened this issue Jun 27, 2023 · 8 comments
Open

Chinese character does not show up #149

johntheocs opened this issue Jun 27, 2023 · 8 comments
Labels
A-font Area: Dealing with font loading/rendering C-bug Category: Something isn't working

Comments

@johntheocs
Copy link

johntheocs commented Jun 27, 2023

I am wondering if this issue is related to font setting or rendering. Thanks for this amazing work.

Screenshot 2023-06-27 at 7 11 29 PM
@CosmicHorrorDev
Copy link
Collaborator

Have you tried using the latest main? There are unreleased changes that add in font fallback support

@johntheocs
Copy link
Author

Yes, it works with the latest main. But the font is a little strange, different from other applications.

@CosmicHorrorDev
Copy link
Collaborator

That could be up to whatever font ends up getting selected. You can set your default regular font in a config file that's described a bit here

https://github.com/trimental/inlyne#configuration

@johntheocs
Copy link
Author

johntheocs commented Jun 27, 2023

Inlyne:
Screenshot 2023-06-27 at 7 56 29 PM

other application (Typora)
Screenshot 2023-06-27 at 7 56 23 PM

Weird. Problems with the bold text and italic, but the normal text is fine.

@CosmicHorrorDev
Copy link
Collaborator

Hmmm, that looks like it may be selecting different fonts for different characters? That does seem really odd

We're currently using a fork of cosmic-text to handle font stuff, so it's possible that the issue will get resolved as cosmic-text matures

@johntheocs
Copy link
Author

Yes, there is an open issue there: pop-os/cosmic-text#114

I am using Zed editor, which is GPU powered too, but does not have this type of issue.

@johntheocs
Copy link
Author

Lapce editor is using a forked version of cosmic-text: https://github.com/lapce/cosmic-text, which works well.

@CosmicHorrorDev
Copy link
Collaborator

CosmicHorrorDev commented Jun 28, 2023

You can try adding that repo as a patch to the Cargo.toml file and see if it resolves the issue. We'll need an actual published version next time we go to cut a release though

@CosmicHorrorDev CosmicHorrorDev added C-bug Category: Something isn't working A-font Area: Dealing with font loading/rendering labels Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-font Area: Dealing with font loading/rendering C-bug Category: Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants