Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made user registration page responsive under #271 #428

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Made user registration page responsive under #271 #428

merged 2 commits into from
Jun 3, 2024

Conversation

Priyal208
Copy link
Contributor

@Priyal208 Priyal208 commented May 29, 2024

Description

User registration page was made responsive under issue assigned to me #271 , i made it responsive using tailwind, fixed margin and padding , made form and image appear in row in mobile view and coloumn in desktop view, adjusted font size for different devices
I did remove image of dog in mobile view as you told me so

Related Issue

Related to #252 and part of #242
GSsoc #271

Screenshots / GIFs (if applicable)

BEFORE(MOBILE VIEW):
Screenshot 2024-05-29 004417
Screenshot 2024-05-29 004435

AFTER(MOBILE AND DESKTOP VIEW) :
Screenshot 2024-05-28 232355
Screenshot 2024-05-29 113843

Checklist:

  • I have performed a self-review of my code
  • I have added/updated relevant documentation (if needed)
  • I have tested the changes locally and they function as expected
  • I have ensured my code follows the project's coding standards

Additional Notes

I deleted old PR and forked new one as you told me since it had earlier commits

@codewarnab
Copy link
Collaborator

good job

@codewarnab codewarnab added gssoc Girl Script Summer of Code level2 25 points labels May 29, 2024
@codewarnab codewarnab requested a review from rishicds May 29, 2024 17:26
@rishicds
Copy link
Collaborator

fix conflicts @Priyal208

@rishicds
Copy link
Collaborator

rishicds commented Jun 3, 2024

fix the conflicts please @Priyal208

@Priyal208
Copy link
Contributor Author

yes

@Priyal208
Copy link
Contributor Author

done @rishicds

@rishicds rishicds merged commit 33c1a33 into Innovateninjas:main Jun 3, 2024
1 check passed
@rishicds
Copy link
Collaborator

rishicds commented Jun 3, 2024

good job @Priyal208

@Priyal208
Copy link
Contributor Author

thank you

@atharvarekhawar
Copy link
Contributor

Hello @rishicds this code is broken please review it once and revert the changes

rishicds added a commit that referenced this pull request Jun 5, 2024
@codewarnab
Copy link
Collaborator

Hello @rishicds this code is broken please review it once and revert the changes

right

codewarnab added a commit that referenced this pull request Jun 5, 2024
This reverts commit 33c1a33.

Co-authored-by: Rishi <124495375+rishicds@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girl Script Summer of Code level2 25 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants