Reset blend equation in renderScene() #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesa was throwing a `GL_INVALID_OPERATION` from the `glDrawArrays` call further down because an advanced blending mode was still enabled, while the scene fragment shader has no `blend_support`. See [this test] in `_mesa_update_valid_to_render_state` for the code which detected this condition. [this test]: https://gitlab.freedesktop.org/mesa/mesa/-/blob/47e7b49c61ed72141b20ee9061a320bd259b3e0d/src/mesa/main/draw_validate.c#L132 The blending mode was likely last set from `inSetBlendMode` in [source/inochi2d/core/nodes/common.d][inSetBlendMode]. [inSetBlendMode]: https://github.com/Inochi2D/inochi2d/blob/d32e41fa7ab900e2fe7fdea0e25f242fcea94de7/source/inochi2d/core/nodes/common.d#L197-L247 This patch resets the blend equation before drawing the scene. Fixes Inochi2D/inochi-session#36.
|
Ah yeah that'd explain it, advanced blend equations only work with one destination texture. LGTM, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mesa was throwing a
GL_INVALID_OPERATIONfrom theglDrawArrayscall further down because an advanced blending mode was still enabled, while the scene fragment shader has noblend_support.See this test in
_mesa_update_valid_to_render_statefor the code which detected this condition.The blending mode was likely last set from
inSetBlendModein source/inochi2d/core/nodes/common.d.This patch resets the blend equation before drawing the scene.
Fixes Inochi2D/inochi-session#36.