Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/component register #1

Merged
merged 5 commits into from
Mar 27, 2019
Merged

Feature/component register #1

merged 5 commits into from
Mar 27, 2019

Conversation

Insality
Copy link
Owner

Почистил фактори, базовые компоненты будут лежать отдельно, пока в папке base

Пока регистрируются криво, дописываются как M["new_" .. module_name]
можеть быть, сделать использование как
но на 1 параметр больше из-за указывания чего
druid:create(druid.button, node_name, ...)

Базовый init от кнопки перенес в button, еще не настраивал, некоторые вещи отключил временно

@Insality Insality requested a review from AGulev March 27, 2019 06:17
Copy link
Collaborator

@AGulev AGulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

function final(self)
-- Add finalization code here
-- Remove this function if not needed
self.button = self.druid:new_button("button", function()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to show parameters of the button's callback in example

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples will be later for all components

@Insality Insality merged commit 1123d09 into develop Mar 27, 2019
@Insality Insality deleted the feature/component_register branch March 27, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants