New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP : Upgrade to spring boot 3.2 #309

Merged

olevitt merged 7 commits into main from spring-boot-3-2

Jan 29, 2024

Contributor

olevitt commented Dec 5, 2023

This PR to track current work in progress to migrate to spring boot 3.2.
Main issue seems to be with our current implementation of helm package URL retrieval which is based on createRelative which seems to have changed behaviour in this spring version. See

onyxia-api/onyxia-api/src/main/java/fr/insee/onyxia/api/dao/universe/CatalogLoader.java

Line 103 in daa7416

.createRelative(chart.getUrls().stream().findFirst().get());

olevitt added 2 commits

December 5, 2023 09:51

WIP

039fe87


          Merge remote-tracking branch 'origin/master' into spring-boot-3-2

5bd0925

sonarcloud bot commented Dec 19, 2023

Quality Gate failed

Failed conditions

1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

olevitt added 3 commits

January 29, 2024 11:23

WIP

7f92cda

RC

1ea6685


          Fix spotless

8608e63

olevitt marked this pull request as ready for review

January 29, 2024 10:38

olevitt added 2 commits

January 29, 2024 11:45


          Fix sonar

fb9dcbd


          Fix sonar

03e91ba

sonarcloud bot commented Jan 29, 2024

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

olevitt merged commit eff2c8d into main

7 checks passed

olevitt deleted the spring-boot-3-2 branch

January 29, 2024 10:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet