Rxr 421 - Unit tests for 2-cmt pk functions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karawoo
approved these changes
Jul 26, 2021
|
|
||
| switch( | ||
| phase, | ||
| "both" = list(alpha = log(2)/alpha, beta = log(2)/beta), |
There was a problem hiding this comment.
Could we either return obj here or remove the where it's defined above?
tests/testthat/test_pk_2cmt_bolus.R
Outdated
Comment on lines
13
to
14
| expect_true(all(c("t", "dv") %in% colnames(res))) | ||
| expect_true(inherits(res, "data.frame")) |
There was a problem hiding this comment.
These are fine expect_named(res, c("t", "dv")) and expect_s3_class(res, "data.frame") would also work and might be a little clearer.
There was a problem hiding this comment.
yeah good idea! I forget about some of the more specific ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was waiting for some things to run so I added a couple unit tests. Along the way I did a bit of clean-up. One functional change: our bolus infusion equations run into some continuity problems as delta_t approaches 0, which made the pk_2cmt_t12_interval() function return -Inf when that didn't make sense, so I added a very small offset, which produces the desired number (as far as I can tell).
Where possible, and as noted in the tests, I verified all the results with PKPDsim.