BUG: fixed valgrind defect in FreeSurfer mesh test

In itkFreeSurferMeshIOTest.cxx updated the order of calls
to avoid uninitialized memory defect. Also removed
Read/WritePointData because there is no test file.
#3772

Author: issakomi

Modules/IO/MeshFreeSurfer/test/CMakeLists.txt

@@ -13,15 +13,15 @@ itk_add_test(NAME itkFreeSurferMeshIOTestAscii
       ${ITK_TEST_OUTPUT_DIR}/fsmeshiosphere.fsa
       DATA{Baseline/sphere.fsb}
       ${ITK_TEST_OUTPUT_DIR}/fsa2fsbsphere.fsb
-      0 1 1 1 1 162 0 320 0 0
+      0 0 0 0 0 162 0 320 0 0
 )
 itk_add_test(NAME itkFreeSurferMeshIOTestBinary
   COMMAND ITKIOMeshFreeSurferTestDriver itkFreeSurferMeshIOTest
       DATA{Baseline/sphere.fsb}
       ${ITK_TEST_OUTPUT_DIR}/fsmeshiosphere.fsb
       DATA{Baseline/sphere.fsa}
       ${ITK_TEST_OUTPUT_DIR}/fsb2fsasphere.fsa
-      0 1 1 1 1 162 0 320 0 1
+      0 0 0 0 0 162 0 320 0 1
 )
 itk_add_test(NAME itkMeshFileReadWriteTestFreeSurfer1
   COMMAND ITKIOMeshFreeSurferTestDriver itkMeshFileReadWriteTest

Modules/IO/MeshFreeSurfer/test/itkFreeSurferMeshIOTest.cxx

@@ -73,59 +73,42 @@ itkFreeSurferMeshIOTestHelper(typename TMeshIO::Pointer       fsMeshIO,
   ITK_TEST_EXPECT_EQUAL(numberOfCells, fsMeshIO->GetNumberOfCells());
   ITK_TEST_EXPECT_EQUAL(numberOfCellPixels, fsMeshIO->GetNumberOfCellPixels());
 
-  // Use sufficiently large buffer sizes
-  itk::SizeValueType pointBufferSize = 2000;
-  itk::SizeValueType pointDataBufferSize = 2000;
-
-  itk::SizeValueType cellBufferSize = 2000;
+  itk::SizeValueType pointBufferSize = 3 * sizeof(float) * fsMeshIO->GetNumberOfPoints();
+  itk::SizeValueType cellBufferSize = 3 * sizeof(uint32_t) * fsMeshIO->GetNumberOfCells();
 
   const std::shared_ptr<void> pointBuffer =
     itk::MeshIOTestHelper::AllocateBuffer(fsMeshIO->GetPointComponentType(), pointBufferSize);
-  const std::shared_ptr<void> pointDataBuffer =
-    itk::MeshIOTestHelper::AllocateBuffer(fsMeshIO->GetPointPixelComponentType(), pointDataBufferSize);
   const std::shared_ptr<void> cellBuffer =
     itk::MeshIOTestHelper::AllocateBuffer(fsMeshIO->GetCellComponentType(), cellBufferSize);
 
   ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->ReadPoints(pointBuffer.get()));
-  ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->ReadPointData(pointDataBuffer.get()));
-
   ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->ReadCells(cellBuffer.get()));
 
-  void * cellDataBuffer = nullptr;
   // Not used; empty method body; called for coverage purposes
-  fsMeshIO->ReadCellData(cellDataBuffer);
+  fsMeshIO->ReadCellData(nullptr);
 
   // Test writing exceptions
   fsMeshIO->SetFileName("");
+  ITK_TRY_EXPECT_EXCEPTION(fsMeshIO->WriteMeshInformation());
   ITK_TRY_EXPECT_EXCEPTION(fsMeshIO->WritePoints(pointBuffer.get()));
-  if (dynamic_cast<itk::FreeSurferBinaryMeshIO *>(fsMeshIO.GetPointer()))
-  {
-    ITK_TRY_EXPECT_EXCEPTION(fsMeshIO->WritePointData(pointDataBuffer.get()));
-  }
-
   ITK_TRY_EXPECT_EXCEPTION(fsMeshIO->WriteCells(cellBuffer.get()));
-  ITK_TRY_EXPECT_EXCEPTION(fsMeshIO->WriteMeshInformation());
 
   ITK_TEST_EXPECT_TRUE(!fsMeshIO->CanWriteFile(notAFsOutputFileName));
 
   ITK_TEST_EXPECT_TRUE(fsMeshIO->CanWriteFile(outputFileName));
   fsMeshIO->SetFileName(outputFileName);
 
   // Write the actual data
+  ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->WriteMeshInformation());
   ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->WritePoints(pointBuffer.get()));
-  ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->WritePointData(pointDataBuffer.get()));
-
   ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->WriteCells(cellBuffer.get()));
 
   // Not used; empty method body; called for coverage purposes
-  fsMeshIO->WriteCellData(cellDataBuffer);
-
-  ITK_TRY_EXPECT_NO_EXCEPTION(fsMeshIO->WriteMeshInformation());
+  fsMeshIO->WriteCellData(nullptr);
 
   // Not used; empty method body; called for coverage purposes
   fsMeshIO->Write();
 
-
   // Read back the written image and check the properties
   readWritefsMeshIO->SetFileName(outputFileName);
   readWritefsMeshIO->ReadMeshInformation();