BUG: Double scaling introduced in refactoring

hjmjohnson · thewtex · commit 355c6cbda3df · 2020-05-05T23:49:36.000-04:00
The moving marginal pdf was double scaled by the normalization factor.

During the previous refactorings the scaling was decoupled from
the computations for the fixed and marginal computations, but
was not removed from the subsequent marginal computation.

Printf trace dumps of every variable value before and after
April 10, 2020 changes.
diff --git a/Modules/Registration/Metricsv4/include/itkMattesMutualInformationImageToImageMetricv4.hxx b/Modules/Registration/Metricsv4/include/itkMattesMutualInformationImageToImageMetricv4.hxx
@@ -358,7 +358,6 @@ MattesMutualInformationImageToImageMetricv4<TFixedImage,
       {
         currMarginalBin += *colptr;
       }
-      currMarginalBin *= normalizationFactor;
     }
   }
 
diff --git a/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.md5 b/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.md5
@@ -1 +1 @@
-c40bf186ebd70003837afc65d999f8f1
+1fa40e8d13e22f06fefb518a9115acbd
diff --git a/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.sha512 b/Testing/Data/Baseline/Registration/ImageRegistration4Test.png.sha512

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,6 @@ MattesMutualInformationImageToImageMetricv4<TFixedImage,`
`358`	`358`	`{`
`359`	`359`	`currMarginalBin += *colptr;`
`360`	`360`	`}`
`361`		`- currMarginalBin *= normalizationFactor;`
`362`	`361`	`}`
`363`	`362`	`}`
`364`	`363`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-c40bf186ebd70003837afc65d999f8f1`
	`1`	`+1fa40e8d13e22f06fefb518a9115acbd`