Skip to content

Commit 42160f8

Browse files
PranjalSahudzenanz
authored andcommitted
COMP: Read Only access to GaussCurvatureData
To remove legacy code "itkGetObjectMacro should be replaced with itkGetModifiableObjectMacro or itkGetConstObjectMacro" We intend to only provide read access to the calculated curvature data so using itkGetConstObjectMacro.
1 parent fab7112 commit 42160f8

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

Modules/Core/Mesh/include/itkTriangleMeshCurvatureCalculator.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ class ITK_TEMPLATE_EXPORT TriangleMeshCurvatureCalculator : public Object
107107
itkSetObjectMacro(TriangleMesh, InputMeshType);
108108

109109
/** Get Gauss curvature. */
110-
itkGetModifiableObjectMacro(GaussCurvatureData, DoubleVectorContainer);
110+
itkGetConstObjectMacro(GaussCurvatureData, DoubleVectorContainer);
111111

112112
/** Set the curvature type to Guass. */
113113
void

Modules/Core/Mesh/test/itkTriangleMeshCurvatureCalculatorTest.cxx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ itkTriangleMeshCurvatureCalculatorTest(int argc, char * argv[])
4141
// Exercise basic object methods
4242
ITK_EXERCISE_BASIC_OBJECT_METHODS(curvCalculator, TriangleMeshCurvatureCalculator, Object);
4343

44-
using DoubleVectorContainerPointer = typename CurvatureCalculatorType::DoubleVectorContainerPointer;
45-
4644
// Test for empty mesh, curvature data should be null.
4745
TriangleMeshType::Pointer triangleMesh = TriangleMeshType::New();
4846

@@ -68,7 +66,7 @@ itkTriangleMeshCurvatureCalculatorTest(int argc, char * argv[])
6866
curvCalculator->Compute();
6967

7068
// Output should be null for empty mesh.
71-
DoubleVectorContainerPointer gaussCurvatureData = curvCalculator->GetModifiableGaussCurvatureData();
69+
auto gaussCurvatureData = curvCalculator->GetGaussCurvatureData();
7270
ITK_TEST_EXPECT_TRUE(gaussCurvatureData == nullptr);
7371

7472

@@ -173,7 +171,7 @@ itkTriangleMeshCurvatureCalculatorTest(int argc, char * argv[])
173171
curvCalculator->Compute();
174172

175173
gaussCurvatureData = curvCalculator->GetGaussCurvatureData();
176-
ITK_TEST_EXPECT_TRUE(gaussCurvatureData->Size() == inputMesh->GetNumberOfPoints())
174+
ITK_TEST_EXPECT_TRUE(gaussCurvatureData->Size() == inputMesh->GetNumberOfPoints());
177175
}
178176

179177
return EXIT_SUCCESS;

0 commit comments

Comments
 (0)