Skip to content

Commit 6c32f95

Browse files
committed
ENH: Improve progress for GradientMagnitudeRecursiveGaussianImageFilter
1 parent 6f23810 commit 6c32f95

File tree

1 file changed

+13
-2
lines changed

1 file changed

+13
-2
lines changed

Modules/Filtering/ImageGradient/include/itkGradientMagnitudeRecursiveGaussianImageFilter.hxx

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,16 @@ GradientMagnitudeRecursiveGaussianImageFilter<TInputImage, TOutputImage>::Genera
187187

188188
typename TOutputImage::Pointer outputImage(this->GetOutput());
189189

190+
// Reset progress of internal filters to zero,
191+
// otherwise progress starts from non-zero value the second time the filter is invoked.
192+
m_DerivativeFilter->UpdateProgress(0.0);
193+
for (unsigned int k = 0; k < ImageDimension - 1; ++k)
194+
{
195+
m_SmoothingFilters[k]->UpdateProgress(0.0);
196+
}
197+
m_SqrSpacingFilter->UpdateProgress(0.0);
198+
m_SqrtFilter->UpdateProgress(0.0);
199+
190200
// Create a process accumulator for tracking the progress of this minipipeline
191201
auto progress = ProgressAccumulator::New();
192202
progress->SetMiniPipelineFilter(this);
@@ -208,13 +218,14 @@ GradientMagnitudeRecursiveGaussianImageFilter<TInputImage, TOutputImage>::Genera
208218

209219
m_DerivativeFilter->SetInput(inputImage);
210220

211-
const unsigned int numberOfFilterRuns = ImageDimension * ImageDimension;
221+
const unsigned int numberOfFilterRuns = 1 + ImageDimension * (ImageDimension + 1);
212222
progress->RegisterInternalFilter(m_DerivativeFilter, 1.0f / numberOfFilterRuns);
213-
214223
for (unsigned int k = 0; k < ImageDimension - 1; ++k)
215224
{
216225
progress->RegisterInternalFilter(m_SmoothingFilters[k], 1.0f / numberOfFilterRuns);
217226
}
227+
progress->RegisterInternalFilter(m_SqrSpacingFilter, 1.0f / numberOfFilterRuns);
228+
progress->RegisterInternalFilter(m_SqrtFilter, 1.0f / numberOfFilterRuns);
218229

219230
for (unsigned int dim = 0; dim < ImageDimension; ++dim)
220231
{

0 commit comments

Comments
 (0)