Skip to content

Commit 7ef2496

Browse files
committed
COMP: Mark class destructors with override
Mark class destructors with `override`. Fixes: ``` In file included from /Users/builder/externalModules/Filtering/FFT/test/itkComplexToComplex1DFFTImageFilterTest.cxx:27: In file included from /Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.h:122: In file included from /Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.hxx:23: [CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkVnlComplexToComplex1DFFTImageFilter.h:61:11: warning: '~VnlComplexToComplex1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] virtual ~VnlComplexToComplex1DFFTImageFilter() {} ^ ``` and ``` In file included from /Users/builder/externalModules/Filtering/FFT/test/itkFFT1DImageFilterTest.cxx:25: In file included from /Users/builder/externalModules/Filtering/FFT/test/itkForward1DFFTImageFilterTest.cxx:27: In file included from /Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.h:101: In file included from /Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.hxx:23: [CTest: warning matched] /Users/builder/externalModules/Filtering/FFT/include/itkVnlForward1DFFTImageFilter.h:62:11: warning: '~VnlForward1DFFTImageFilter' overrides a destructor but is not marked 'override' [-Winconsistent-missing-destructor-override] virtual ~VnlForward1DFFTImageFilter() {} ^ ``` raised for example at: https://open.cdash.org/viewBuildError.php?type=1&onlydeltap&buildid=7512728
1 parent 625d449 commit 7ef2496

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Modules/Filtering/FFT/include/itkVnlComplexToComplex1DFFTImageFilter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class ITK_TEMPLATE_EXPORT VnlComplexToComplex1DFFTImageFilter
5858

5959
protected:
6060
VnlComplexToComplex1DFFTImageFilter() {}
61-
virtual ~VnlComplexToComplex1DFFTImageFilter() {}
61+
~VnlComplexToComplex1DFFTImageFilter() override{};
6262

6363
void
6464
GenerateData() override;

Modules/Filtering/FFT/include/itkVnlForward1DFFTImageFilter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class ITK_TEMPLATE_EXPORT VnlForward1DFFTImageFilter : public Forward1DFFTImageF
5959
GenerateData() override;
6060

6161
VnlForward1DFFTImageFilter() {}
62-
virtual ~VnlForward1DFFTImageFilter() {}
62+
~VnlForward1DFFTImageFilter() override{};
6363

6464
private:
6565
};

0 commit comments

Comments
 (0)