ENH: Increase coverage for miscellaneous classes

Increase coverage for miscellaneous classes:
- Exercise basic object methods using the
  `ITK_EXERCISE_BASIC_OBJECT_METHODS` macro. Remove redundant calls to
  print the filter or its class name.
- Test the Set/Get methods using the `ITK_TEST_SET_GET_VALUE` macro.
- Test the boolean ivars using the `ITK_TEST_SET_GET_BOOLEAN` macro.
- Refactor the tests to accept (more) input parameters to allow checking
  the classes under a broader range of conditions.
- Fix a bug in the `itkOpeningByReconstructionImageFilterTest2.cxx` file
  where the argument checking related to the optional output difference
  image was using a smaller value than the correct one for the
  comparison. The bug had gone unnoticed because all related tests in
  the `CMakeLists.txt` file had a value for the optional difference
  image argument.
- Fix a bug in `itkCollidingFrontsImageFilterTest.cxx` file where no
  input image file is being allowed in practice, and the output image
  file argument was using the wrong argument index. The bug had gone
  unnoticed because no output filename is being provided in the
  `CMakeLists.txt` tests.

Author: jhlegarreta

Modules/Core/Mesh/test/itkSphereMeshSourceTest.cxx

@@ -17,6 +17,7 @@
  *=========================================================================*/
 
 #include "itkSphereMeshSource.h"
+#include "itkTestingMacros.h"
 #include <iostream>
 
 int
@@ -25,7 +26,11 @@ itkSphereMeshSourceTest(int, char *[])
 
   using fPointType = itk::Point<float, 3>;
   using fSphereMeshSourceType = itk::SphereMeshSource<itk::Mesh<float>>;
-  auto       mySphereMeshSource = fSphereMeshSourceType::New();
+  auto mySphereMeshSource = fSphereMeshSourceType::New();
+
+  ITK_EXERCISE_BASIC_OBJECT_METHODS(mySphereMeshSource, SphereMeshSource, MeshSource);
+
+
   fPointType center;
   center.Fill(0);
   fPointType::ValueType scaleInit[3] = { 1, 1, 1 };
@@ -36,11 +41,15 @@ itkSphereMeshSourceTest(int, char *[])
   mySphereMeshSource->SetResolutionY(10);
   mySphereMeshSource->SetScale(scale);
 
+  double squareness1 = 1.0;
+  mySphereMeshSource->SetSquareness1(squareness1);
+
+  double squareness2 = 1.0;
+  mySphereMeshSource->SetSquareness2(squareness2);
+
   mySphereMeshSource->Modified();
   mySphereMeshSource->Update();
 
-  std::cout << "mySphereMeshSource: " << mySphereMeshSource;
-
   using IPT = itk::Mesh<float>::PointType;
   //  itk::Mesh<float>::PointsContainerPointer      myoutput = mySphereMeshSource->GetOutput()->GetPoints();
   //  itk::Mesh<float>::PointsContainer::Iterator   m_output = myoutput->Begin();

Modules/Core/SpatialObjects/test/itkMeshSpatialObjectTest.cxx

@@ -61,6 +61,10 @@ itkMeshSpatialObjectTest(int, char *[])
   ITK_EXERCISE_BASIC_OBJECT_METHODS(meshSO, MeshSpatialObject, SpatialObject);
 
 
+  double isInsidePrecisionInObjectSpace = 1;
+  meshSO->SetIsInsidePrecisionInObjectSpace(isInsidePrecisionInObjectSpace);
+  ITK_TEST_SET_GET_VALUE(isInsidePrecisionInObjectSpace, meshSO->GetIsInsidePrecisionInObjectSpace());
+
   meshSO->SetMesh(mesh);
   ITK_TEST_SET_GET_VALUE(mesh, meshSO->GetMesh());
 

Modules/Filtering/AnisotropicSmoothing/test/itkVectorAnisotropicDiffusionImageFilterTest.cxx

@@ -67,6 +67,11 @@ itkVectorAnisotropicDiffusionImageFilterTest(int itkNotUsed(argc), char * itkNot
     // Set up Curvature diffusion filter
     itk::VectorCurvatureAnisotropicDiffusionImageFilter<ImageType, ImageType>::Pointer filter2 =
       itk::VectorCurvatureAnisotropicDiffusionImageFilter<ImageType, ImageType>::New();
+
+    ITK_EXERCISE_BASIC_OBJECT_METHODS(
+      filter2, VectorCurvatureAnisotropicDiffusionImageFilter, AnisotropicDiffusionImageFilter);
+
+
     filter2->SetNumberOfIterations(1);
     filter2->SetConductanceParameter(3.0f);
     filter2->SetTimeStep(0.1f);

Modules/Filtering/DiffusionTensorImage/test/itkDiffusionTensor3DReconstructionImageFilterTest.cxx

@@ -118,7 +118,33 @@ itkDiffusionTensor3DReconstructionImageFilterTest(int argc, char * argv[])
       gradientDirection[2] = gradientDirections[i][2];
       tensorReconstructionFilter->AddGradientImage(gradientDirection, gradientImage);
       std::cout << "Gradient directions: " << gradientDirection << std::endl;
+
+      const TensorReconstructionImageFilterType::GradientDirectionType::element_type epsilon = 1e-3;
+      TensorReconstructionImageFilterType::GradientDirectionType                     output =
+        tensorReconstructionFilter->GetGradientDirection(i);
+      for (unsigned int j = 0; j < gradientDirection.size(); ++j)
+      {
+        TensorReconstructionImageFilterType::GradientDirectionType::element_type gradientDirectionComponent =
+          gradientDirection[j];
+        TensorReconstructionImageFilterType::GradientDirectionType::element_type outputComponent = output[j];
+        if (!itk::Math::FloatAlmostEqual(gradientDirectionComponent, outputComponent, 10, epsilon))
+        {
+          std::cerr.precision(static_cast<int>(itk::Math::abs(std::log10(epsilon))));
+          std::cerr << "Test failed!" << std::endl;
+          std::cerr << "Error in gradientDirection [" << i << "]"
+                    << "[" << j << "]" << std::endl;
+          std::cerr << "Expected value " << gradientDirectionComponent << std::endl;
+          std::cerr << " differs from " << outputComponent;
+          std::cerr << " by more than " << epsilon << std::endl;
+          return EXIT_FAILURE;
+        }
+      }
     }
+
+    // Test gradient direction index exception
+    unsigned int idx = numberOfGradientImages + 1;
+    ITK_TRY_EXPECT_EXCEPTION(tensorReconstructionFilter->GetGradientDirection(idx));
+
     //
     // second time through test, use the mask image
     if (pass == 1)

Modules/Filtering/DisplacementField/test/itkDisplacementFieldTransformTest.cxx

@@ -178,6 +178,12 @@ itkDisplacementFieldTransformTest(int argc, char * argv[])
   ITK_EXERCISE_BASIC_OBJECT_METHODS(displacementTransform, DisplacementFieldTransform, Transform);
 
 
+  // Test exceptions
+  DisplacementTransformType::InputVnlVectorType::element_type vectorValue = 1.0;
+  DisplacementTransformType::InputVnlVectorType               vector;
+  vector.fill(vectorValue);
+  ITK_TRY_EXPECT_EXCEPTION(displacementTransform->TransformVector(vector));
+
   DisplacementTransformType::DisplacementFieldType::Pointer displacementField =
     DisplacementTransformType::DisplacementFieldType::New();
   displacementTransform->SetDisplacementField(displacementField);

Modules/Filtering/FFT/test/itkFullToHalfHermitianImageFilterTest.cxx

@@ -75,9 +75,14 @@ itkFullToHalfHermitianImageFilterTest(int argc, char * argv[])
 
   using FullToHalfFilterType = itk::FullToHalfHermitianImageFilter<ComplexImageType>;
   auto fullToHalfFilter = FullToHalfFilterType::New();
+
+  ITK_EXERCISE_BASIC_OBJECT_METHODS(fullToHalfFilter, FullToHalfHermitianImageFilter, ImageToImageFilter);
+
+
   fullToHalfFilter->SetInput(halfToFullFilter->GetOutput());
   fullToHalfFilter->Update();
-  fullToHalfFilter->Print(std::cout);
+
+  std::cout << "ActualXDimensionIsOdd: " << fullToHalfFilter->GetActualXDimensionIsOdd() << std::endl;
 
   // Check that the output of the full-to-half filter has the same
   // size as the output of the FFT filter.

Modules/Filtering/ImageStatistics/test/itkImagePCADecompositionCalculatorTest.cxx

@@ -322,6 +322,7 @@ itkImagePCADecompositionCalculatorTest(int, char *[])
   ImagePCAShapeModelEstimatorType::BasisVectorType proj3_3, proj4_3;
   // now test it with a mean image set
   decomposer->SetMeanImage(image8);
+  ITK_TEST_SET_GET_VALUE(image8, decomposer->GetMeanImage());
 
   decomposer->SetImage(image3);
   decomposer->Compute();

Modules/Filtering/MathematicalMorphology/test/Baseline/ClosingByReconstructionImageFilterTestFullyConnected.png.sha512

@@ -0,0 +1 @@
+92e736905e044fa0a29ace07cce3175e14a15959c69c595b3a9059d218f01fc755f8a1ce1ed8d036743331b06ee6c3d05ffff45fe20631778b4e851ebc96a227

Modules/Filtering/MathematicalMorphology/test/Baseline/OpeningByReconstructionImageFilterTestFullyConnected.png.sha512

@@ -0,0 +1 @@
+171ca81f508d58809aa9b8323de9f9d7cab85a5059a7663417a0a32ae2a732f947f30a5b43b5e4f623f33bcb9d9212a9c66c18a69a506d4caa264155c362758a

Modules/Filtering/MathematicalMorphology/test/CMakeLists.txt

@@ -64,12 +64,17 @@ itk_add_test(NAME itkClosingByReconstructionImageFilterTest
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{${ITK_DATA_ROOT}/Baseline/BasicFilters/ClosingByReconstructionImageFilterTest.png}
               ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest.png
-    itkClosingByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/closerec1.jpg} ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest.png 4 0 ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestSubtract.png)
+    itkClosingByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/closerec1.jpg} ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest.png 4 0 0 ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestSubtract.png)
 itk_add_test(NAME itkClosingByReconstructionImageFilterTest2
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{${ITK_DATA_ROOT}/Baseline/BasicFilters/ClosingByReconstructionImageFilterTest2.png}
               ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest2.png
-    itkClosingByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/closerec1.jpg} ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest2.png 4 1 ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestSubtract2.png)
+    itkClosingByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/closerec1.jpg} ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTest2.png 4 1 0 ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestSubtract2.png)
+itk_add_test(NAME itkClosingByReconstructionImageFilterTestFullyConnected
+      COMMAND ITKMathematicalMorphologyTestDriver
+    --compare DATA{Baseline/ClosingByReconstructionImageFilterTestFullyConnected.png}
+              ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestFullyConnected.png
+    itkClosingByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/closerec1.jpg} ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestFullyConnected.png 4 1 1 ${ITK_TEST_OUTPUT_DIR}/ClosingByReconstructionImageFilterTestSubtractFullyConnected.png)
 itk_add_test(NAME itkFlatStructuringElementTest
       COMMAND ITKMathematicalMorphologyTestDriver
               --redirectOutput ${ITK_TEST_OUTPUT_DIR}/itkFlatStructuringElementTest.txt
@@ -226,22 +231,27 @@ itk_add_test(NAME itkOpeningByReconstructionImageFilterTest
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{${ITK_DATA_ROOT}/Baseline/BasicFilters/OpeningByReconstructionImageFilterTest.png}
               ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest.png
-    itkOpeningByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/chondt.png} ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest.png 4 0 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtract.png)
+    itkOpeningByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/chondt.png} ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest.png 4 0 0 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtract.png)
 itk_add_test(NAME itkOpeningByReconstructionImageFilterTest2
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{${ITK_DATA_ROOT}/Baseline/BasicFilters/OpeningByReconstructionImageFilterTest2.png}
               ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest2.png
-    itkOpeningByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/chondt.png} ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest2.png 4 1 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtract2.png)
+    itkOpeningByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/chondt.png} ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTest2.png 4 1 0 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtract2.png)
+itk_add_test(NAME itkOpeningByReconstructionImageFilterTestFullyConnected
+      COMMAND ITKMathematicalMorphologyTestDriver
+    --compare DATA{Baseline/OpeningByReconstructionImageFilterTestFullyConnected.png}
+              ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestFullyConnected.png
+    itkOpeningByReconstructionImageFilterTest DATA{${ITK_DATA_ROOT}/Input/chondt.png} ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestFullyConnected.png 4 1 1 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtractFullyConnected.png)
 itk_add_test(NAME itkOpeningByReconstructionImageFilterTestNoInput
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{Baseline/OpeningByReconstructionImageFilterTestNoInput.png}
               ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput.png
-    itkOpeningByReconstructionImageFilterTest2 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput.png 4 0 0 0 0.5 0.5 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtractNoInput.png)
+    itkOpeningByReconstructionImageFilterTest2 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput.png 4 0 0 0 0 0.5 0.5 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtractNoInput.png)
 itk_add_test(NAME itkOpeningByReconstructionImageFilterTestNoInput2
       COMMAND ITKMathematicalMorphologyTestDriver
     --compare DATA{Baseline/OpeningByReconstructionImageFilterTestNoInput2.png}
               ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput2.png
-    itkOpeningByReconstructionImageFilterTest2 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput2.png 4 1 0 0 0.5 0.5 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtractNoInput2.png)
+    itkOpeningByReconstructionImageFilterTest2 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestNoInput2.png 4 1 0 0 0 0.5 0.5 ${ITK_TEST_OUTPUT_DIR}/OpeningByReconstructionImageFilterTestSubtractNoInput2.png)
 itk_add_test(NAME itkDoubleThresholdImageFilterTest
       COMMAND ITKMathematicalMorphologyTestDriver
   --compare DATA{${ITK_DATA_ROOT}/Baseline/BasicFilters/DoubleThresholdImageFilterTest.png}