ENH: Remove ivar memberless/static-only class PrinSelf

jhlegarreta · dzenanz · commit d2ff3110f198 · 2023-01-16T11:05:04.000-05:00
Remove `PrinSelf` re-implementations in classes that:
- do not contain instance variable members: their parent class
  re-implementation prints the necessary information.
- contain only static variable members.
diff --git a/Modules/Core/Common/include/itkNeighborhoodIterator.h b/Modules/Core/Common/include/itkNeighborhoodIterator.h
@@ -254,10 +254,6 @@ class ITK_TEMPLATE_EXPORT NeighborhoodIterator : public ConstNeighborhoodIterato
     : Superclass(radius, ptr, region)
   {}
 
-  /** Standard print method */
-  void
-  PrintSelf(std::ostream &, Indent) const override;
-
   /** Returns the central memory pointer of the neighborhood. */
   InternalPixelType *
   GetCenterPointer()
diff --git a/Modules/Core/Common/include/itkNeighborhoodIterator.hxx b/Modules/Core/Common/include/itkNeighborhoodIterator.hxx
@@ -143,15 +143,6 @@ NeighborhoodIterator<TImage, TBoundaryCondition>::SetPixel(const unsigned int n,
   }
 }
 
-template <typename TImage, typename TBoundaryCondition>
-void
-NeighborhoodIterator<TImage, TBoundaryCondition>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  os << indent;
-  os << "NeighborhoodIterator {this= " << this << "}" << std::endl;
-  Superclass::PrintSelf(os, indent.GetNextIndent());
-}
-
 template <typename TImage, typename TBoundaryCondition>
 void
 NeighborhoodIterator<TImage, TBoundaryCondition>::SetNeighborhood(const NeighborhoodType & N)
diff --git a/Modules/Core/Common/include/itkShapedNeighborhoodIterator.h b/Modules/Core/Common/include/itkShapedNeighborhoodIterator.h
@@ -238,10 +238,6 @@ class ITK_TEMPLATE_EXPORT ShapedNeighborhoodIterator
     return *this;
   }
 
-  /** Standard itk print method */
-  void
-  PrintSelf(std::ostream &, Indent) const override;
-
   /** Returns a const iterator for the neighborhood which points to the first
    * pixel in the neighborhood. */
   Iterator
@@ -265,8 +261,4 @@ class ITK_TEMPLATE_EXPORT ShapedNeighborhoodIterator
 };
 } // namespace itk
 
-#ifndef ITK_MANUAL_INSTANTIATION
-#  include "itkShapedNeighborhoodIterator.hxx"
-#endif
-
 #endif
diff --git a/Modules/Core/Common/include/itkShapedNeighborhoodIterator.hxx b/Modules/Core/Common/include/itkShapedNeighborhoodIterator.hxx
diff --git a/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateImageFunction.h b/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateImageFunction.h
@@ -94,8 +94,6 @@ class ITK_TEMPLATE_EXPORT VectorLinearInterpolateImageFunction
 protected:
   VectorLinearInterpolateImageFunction() = default;
   ~VectorLinearInterpolateImageFunction() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
 private:
   /** Number of neighbors used in the interpolation */
diff --git a/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateImageFunction.hxx b/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateImageFunction.hxx
@@ -30,15 +30,6 @@ template <typename TInputImage, typename TCoordRep>
 const unsigned long VectorLinearInterpolateImageFunction<TInputImage, TCoordRep>::m_Neighbors =
   1 << TInputImage::ImageDimension;
 
-/**
- * PrintSelf
- */
-template <typename TInputImage, typename TCoordRep>
-void
-VectorLinearInterpolateImageFunction<TInputImage, TCoordRep>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  this->Superclass::PrintSelf(os, indent);
-}
 
 /**
  * Evaluate at image index position
diff --git a/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateNearestNeighborExtrapolateImageFunction.h b/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateNearestNeighborExtrapolateImageFunction.h
@@ -137,9 +137,6 @@ class ITK_TEMPLATE_EXPORT VectorLinearInterpolateNearestNeighborExtrapolateImage
   VectorLinearInterpolateNearestNeighborExtrapolateImageFunction() = default;
   ~VectorLinearInterpolateNearestNeighborExtrapolateImageFunction() override = default;
 
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
 private:
   /** Number of neighbors used in the interpolation */
   static const unsigned int m_Neighbors;
diff --git a/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateNearestNeighborExtrapolateImageFunction.hxx b/Modules/Core/ImageFunction/include/itkVectorLinearInterpolateNearestNeighborExtrapolateImageFunction.hxx
@@ -30,17 +30,6 @@ template <typename TInputImage, typename TCoordRep>
 const unsigned int VectorLinearInterpolateNearestNeighborExtrapolateImageFunction<TInputImage, TCoordRep>::m_Neighbors =
   1 << TInputImage::ImageDimension;
 
-/**
- * PrintSelf
- */
-template <typename TInputImage, typename TCoordRep>
-void
-VectorLinearInterpolateNearestNeighborExtrapolateImageFunction<TInputImage, TCoordRep>::PrintSelf(std::ostream & os,
-                                                                                                  Indent indent) const
-{
-  this->Superclass::PrintSelf(os, indent);
-}
-
 /**
  * Evaluate at image index position
  */
diff --git a/Modules/Core/SpatialObjects/include/itkDTITubeSpatialObject.h b/Modules/Core/SpatialObjects/include/itkDTITubeSpatialObject.h
@@ -72,10 +72,6 @@ class ITK_TEMPLATE_EXPORT DTITubeSpatialObject
   DTITubeSpatialObject();
   ~DTITubeSpatialObject() override = default;
 
-  /** Method to print the object.*/
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
   typename LightObject::Pointer
   InternalClone() const override;
 };
diff --git a/Modules/Core/SpatialObjects/include/itkDTITubeSpatialObject.hxx b/Modules/Core/SpatialObjects/include/itkDTITubeSpatialObject.hxx
@@ -46,14 +46,6 @@ DTITubeSpatialObject<TDimension>::InternalClone() const
   return loPtr;
 }
 
-/** Print the object */
-template <unsigned int TDimension>
-void
-DTITubeSpatialObject<TDimension>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  os << indent << "DTITubeSpatialObject(" << this << ")" << std::endl;
-  Superclass::PrintSelf(os, indent);
-}
 } // end namespace itk
 
 #endif // end itkDTITubeSpatialObject_hxx
diff --git a/Modules/Core/SpatialObjects/include/itkGroupSpatialObject.h b/Modules/Core/SpatialObjects/include/itkGroupSpatialObject.h
@@ -57,10 +57,6 @@ class ITK_TEMPLATE_EXPORT GroupSpatialObject : public SpatialObject<TDimension>
   GroupSpatialObject();
   ~GroupSpatialObject() override = default;
 
-  /** Method to print the object.*/
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
   typename LightObject::Pointer
   InternalClone() const override;
 };
diff --git a/Modules/Core/SpatialObjects/include/itkGroupSpatialObject.hxx b/Modules/Core/SpatialObjects/include/itkGroupSpatialObject.hxx
@@ -46,14 +46,6 @@ GroupSpatialObject<TDimension>::InternalClone() const
   return loPtr;
 }
 
-/** Print the object */
-template <unsigned int TDimension>
-void
-GroupSpatialObject<TDimension>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  os << indent << "GroupSpatialObject(" << this << ")" << std::endl;
-  Superclass::PrintSelf(os, indent);
-}
 } // end namespace itk
 
 #endif // end itkGroupSpatialObject_hxx
diff --git a/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.h b/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.h
@@ -111,9 +111,6 @@ class ITK_TEMPLATE_EXPORT ImageMaskSpatialObject : public ImageSpatialObject<TDi
   ImageMaskSpatialObject();
   ~ImageMaskSpatialObject() override = default;
 
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
   typename LightObject::Pointer
   InternalClone() const override;
 };
diff --git a/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.hxx b/Modules/Core/SpatialObjects/include/itkImageMaskSpatialObject.hxx
@@ -133,15 +133,6 @@ ImageMaskSpatialObject<TDimension, TPixel>::InternalClone() const
   return loPtr;
 }
 
-/** Print the object */
-template <unsigned int TDimension, typename TPixel>
-void
-ImageMaskSpatialObject<TDimension, TPixel>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  Superclass::PrintSelf(os, indent);
-}
-
-
 template <unsigned int TDimension, typename TPixel>
 auto
 ImageMaskSpatialObject<TDimension, TPixel>::ComputeMyBoundingBoxInIndexSpace() const -> RegionType
diff --git a/Modules/Core/SpatialObjects/include/itkLineSpatialObject.h b/Modules/Core/SpatialObjects/include/itkLineSpatialObject.h
@@ -81,10 +81,6 @@ class ITK_TEMPLATE_EXPORT LineSpatialObject
   LineSpatialObject();
   ~LineSpatialObject() override = default;
 
-  /** Method to print the object. */
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
   typename LightObject::Pointer
   InternalClone() const override;
 };
diff --git a/Modules/Core/SpatialObjects/include/itkLineSpatialObject.hxx b/Modules/Core/SpatialObjects/include/itkLineSpatialObject.hxx
@@ -50,15 +50,6 @@ LineSpatialObject<TDimension>::InternalClone() const
   return loPtr;
 }
 
-/** Print the object. */
-template <unsigned int TDimension>
-void
-LineSpatialObject<TDimension>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  os << indent << "LineSpatialObject(" << this << ")" << std::endl;
-  Superclass::PrintSelf(os, indent);
-}
-
 template <unsigned int TDimension>
 bool
 LineSpatialObject<TDimension>::IsInsideInObjectSpace(const PointType & point) const
diff --git a/Modules/Core/SpatialObjects/include/itkSurfaceSpatialObject.h b/Modules/Core/SpatialObjects/include/itkSurfaceSpatialObject.h
@@ -85,10 +85,6 @@ class ITK_TEMPLATE_EXPORT SurfaceSpatialObject
   SurfaceSpatialObject();
   ~SurfaceSpatialObject() override = default;
 
-  /** Method to print the object.*/
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
-
   typename LightObject::Pointer
   InternalClone() const override;
 };
diff --git a/Modules/Core/SpatialObjects/include/itkSurfaceSpatialObject.hxx b/Modules/Core/SpatialObjects/include/itkSurfaceSpatialObject.hxx
@@ -66,15 +66,6 @@ SurfaceSpatialObject<TDimension, TSurfacePointType>::InternalClone() const
   return loPtr;
 }
 
-/** Print the surface object */
-template <unsigned int TDimension, typename TSurfacePointType>
-void
-SurfaceSpatialObject<TDimension, TSurfacePointType>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  os << indent << "SurfaceSpatialObject(" << this << ")" << std::endl;
-  Superclass::PrintSelf(os, indent);
-}
-
 #if !defined(ITK_LEGACY_REMOVE)
 /** Approximate the normals of the surface */
 template <unsigned int TDimension, typename TSurfacePointType>
diff --git a/Modules/Core/Transform/include/itkAffineTransform.h b/Modules/Core/Transform/include/itkAffineTransform.h
@@ -281,9 +281,6 @@ class ITK_TEMPLATE_EXPORT AffineTransform
   /** Destroy an AffineTransform object   */
   ~AffineTransform() override = default;
 
-  /** Print contents of an AffineTransform */
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 }; // class AffineTransform
 
 } // namespace itk
diff --git a/Modules/Core/Transform/include/itkAffineTransform.hxx b/Modules/Core/Transform/include/itkAffineTransform.hxx
@@ -42,14 +42,6 @@ AffineTransform<TParametersValueType, VDimension>::AffineTransform(const MatrixT
   : Superclass(matrix, offset)
 {}
 
-/** Print self */
-template <typename TParametersValueType, unsigned int VDimension>
-void
-AffineTransform<TParametersValueType, VDimension>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  Superclass::PrintSelf(os, indent);
-}
-
 /** Compose with a translation */
 template <typename TParametersValueType, unsigned int VDimension>
 void
diff --git a/Modules/Filtering/GPUAnisotropicSmoothing/include/itkGPUAnisotropicDiffusionImageFilter.h b/Modules/Filtering/GPUAnisotropicSmoothing/include/itkGPUAnisotropicDiffusionImageFilter.h
@@ -67,8 +67,6 @@ class ITK_TEMPLATE_EXPORT GPUAnisotropicDiffusionImageFilter
 protected:
   GPUAnisotropicDiffusionImageFilter() = default;
   ~GPUAnisotropicDiffusionImageFilter() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
   /** Prepare for the iteration process. */
   void
diff --git a/Modules/Filtering/GPUAnisotropicSmoothing/include/itkGPUAnisotropicDiffusionImageFilter.hxx b/Modules/Filtering/GPUAnisotropicSmoothing/include/itkGPUAnisotropicDiffusionImageFilter.hxx
@@ -90,14 +90,6 @@ GPUAnisotropicDiffusionImageFilter<TInputImage, TOutputImage, TParentImageFilter
   }
 }
 
-template <typename TInputImage, typename TOutputImage, typename TParentImageFilter>
-void
-GPUAnisotropicDiffusionImageFilter<TInputImage, TOutputImage, TParentImageFilter>::PrintSelf(std::ostream & os,
-                                                                                             Indent indent) const
-{
-  GPUSuperclass::PrintSelf(os, indent.GetNextIndent());
-}
-
 } // end namespace itk
 
 #endif
diff --git a/Modules/Numerics/Statistics/include/itkMeanSampleFilter.h b/Modules/Numerics/Statistics/include/itkMeanSampleFilter.h
@@ -106,8 +106,6 @@ class ITK_TEMPLATE_EXPORT MeanSampleFilter : public ProcessObject
 protected:
   MeanSampleFilter();
   ~MeanSampleFilter() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
   /** DataObject pointer */
   using DataObjectPointer = DataObject::Pointer;
diff --git a/Modules/Numerics/Statistics/include/itkMeanSampleFilter.hxx b/Modules/Numerics/Statistics/include/itkMeanSampleFilter.hxx
@@ -36,13 +36,6 @@ MeanSampleFilter<TSample>::MeanSampleFilter()
   this->ProcessObject::SetNthOutput(0, this->MakeOutput(0));
 }
 
-template <typename TSample>
-void
-MeanSampleFilter<TSample>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  Superclass::PrintSelf(os, indent);
-}
-
 template <typename TSample>
 void
 MeanSampleFilter<TSample>::SetInput(const SampleType * sample)
diff --git a/Modules/Numerics/Statistics/include/itkWeightedCovarianceSampleFilter.h b/Modules/Numerics/Statistics/include/itkWeightedCovarianceSampleFilter.h
@@ -102,8 +102,6 @@ class ITK_TEMPLATE_EXPORT WeightedCovarianceSampleFilter : public CovarianceSamp
 protected:
   WeightedCovarianceSampleFilter();
   ~WeightedCovarianceSampleFilter() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
   void
   GenerateData() override;
diff --git a/Modules/Numerics/Statistics/include/itkWeightedCovarianceSampleFilter.hxx b/Modules/Numerics/Statistics/include/itkWeightedCovarianceSampleFilter.hxx
@@ -30,17 +30,6 @@ WeightedCovarianceSampleFilter<TSample>::WeightedCovarianceSampleFilter()
   this->ProcessObject::SetNthInput(1, nullptr);
 }
 
-template <typename TSample>
-void
-WeightedCovarianceSampleFilter<TSample>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  Superclass::PrintSelf(os, indent);
-  // m_Weights
-  os << indent << "Weights: " << this->GetWeightsInput() << std::endl;
-  // m_WeightingFunction
-  os << indent << "WeightingFunction: " << this->GetWeightingFunctionInput() << std::endl;
-}
-
 template <typename TSample>
 inline void
 WeightedCovarianceSampleFilter<TSample>::GenerateData()
diff --git a/Modules/Numerics/Statistics/include/itkWeightedMeanSampleFilter.h b/Modules/Numerics/Statistics/include/itkWeightedMeanSampleFilter.h
@@ -97,8 +97,6 @@ class ITK_TEMPLATE_EXPORT WeightedMeanSampleFilter : public MeanSampleFilter<TSa
 protected:
   WeightedMeanSampleFilter();
   ~WeightedMeanSampleFilter() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
   void
   GenerateData() override;
diff --git a/Modules/Numerics/Statistics/include/itkWeightedMeanSampleFilter.hxx b/Modules/Numerics/Statistics/include/itkWeightedMeanSampleFilter.hxx
@@ -33,17 +33,6 @@ WeightedMeanSampleFilter<TSample>::WeightedMeanSampleFilter()
   this->ProcessObject::SetNthInput(1, nullptr);
 }
 
-template <typename TSample>
-void
-WeightedMeanSampleFilter<TSample>::PrintSelf(std::ostream & os, Indent indent) const
-{
-  Superclass::PrintSelf(os, indent);
-  // m_Weights
-  os << indent << "Weights: " << this->GetWeightsInput() << std::endl;
-  // m_WeightingFunction
-  os << indent << "Weighting Function: " << this->GetWeightingFunctionInput() << std::endl;
-}
-
 template <typename TSample>
 void
 WeightedMeanSampleFilter<TSample>::GenerateData()
diff --git a/Modules/Registration/Common/include/itkRecursiveMultiResolutionPyramidImageFilter.h b/Modules/Registration/Common/include/itkRecursiveMultiResolutionPyramidImageFilter.h
@@ -109,8 +109,6 @@ class ITK_TEMPLATE_EXPORT RecursiveMultiResolutionPyramidImageFilter
 protected:
   RecursiveMultiResolutionPyramidImageFilter();
   ~RecursiveMultiResolutionPyramidImageFilter() override = default;
-  void
-  PrintSelf(std::ostream & os, Indent indent) const override;
 
   /** Generate the output data. */
   void
diff --git a/Modules/Registration/Common/include/itkRecursiveMultiResolutionPyramidImageFilter.hxx b/Modules/Registration/Common/include/itkRecursiveMultiResolutionPyramidImageFilter.hxx
