COMP: Update for changes to VTK target names #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The targets have changed in VTK Git master. Also call "vtk_module_autoinit" on the test driver, which is required on recent VTK to avoid runtime errors such as; vtkRenderWindow.cxx:35 WARN| Error: no override found for 'vtkRenderWindow'.
hjmjohnson
approved these changes
Apr 27, 2019
|
@thewtex What does it mean when only CDash is holding this up? |
We can ignore the duplicate CDash status checks that are not transitioning from In progress to succeeded and merge -- this is an issue with the hook that I need to address. Thanks for the review. |
|
I can confirm this fixed the issue I reported to @thewtex, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targets have changed in VTK Git master.
Also call "vtk_module_autoinit" on the test driver, which is required on
recent VTK to avoid runtime errors such as;
vtkRenderWindow.cxx:35 WARN| Error: no override found for
'vtkRenderWindow'.
Closes #739