Skip to content

Commit 391e5bc

Browse files
hjmjohnsondzenanz
authored andcommitted
COMP: Remove inclusion of .hxx files as headers
The ability to include either .h or .hxx files as header files required recursively reading the .h files twice. The added complexity is unnecessary, costly, and can confuse static analysis tools that monitor header guardes (due to reaching the maximum depth of recursion limits for nested #ifdefs in checking).
1 parent 893b043 commit 391e5bc

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

include/itkBoneMorphometryFeaturesFilter.hxx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#ifndef itkBoneMorphometryFeaturesFilter_hxx
1919
#define itkBoneMorphometryFeaturesFilter_hxx
2020

21-
#include "itkBoneMorphometryFeaturesFilter.h"
2221

2322
#include "itkImageScanlineIterator.h"
2423
#include "itkProgressReporter.h"

include/itkBoneMorphometryFeaturesImageFilter.hxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#ifndef itkBoneMorphometryFeaturesImageFilter_hxx
1919
#define itkBoneMorphometryFeaturesImageFilter_hxx
2020

21-
#include "itkBoneMorphometryFeaturesImageFilter.h"
2221

2322
#include "itkImageScanlineIterator.h"
2423
#include "itkProgressReporter.h"
@@ -210,7 +209,7 @@ BoneMorphometryFeaturesImageFilter<TInputImage, TOutputImage, TMaskImage>::IsIns
210209
bool insideNeighborhood = true;
211210
for (unsigned int i = 0; i < this->m_NeighborhoodRadius.Dimension; ++i)
212211
{
213-
int boundDistance = m_NeighborhoodRadius[i] - Math::abs(iteratedOffset[i]);
212+
int boundDistance = m_NeighborhoodRadius[i] - itk::Math::abs(iteratedOffset[i]);
214213
if (boundDistance < 0)
215214
{
216215
insideNeighborhood = false;

include/itkReplaceFeatureMapNanInfImageFilter.hxx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
#ifndef itkReplaceFeatureMapNanInfImageFilter_hxx
1919
#define itkReplaceFeatureMapNanInfImageFilter_hxx
2020

21-
#include "itkReplaceFeatureMapNanInfImageFilter.h"
2221

2322
namespace itk
2423
{

0 commit comments

Comments
 (0)