Add symlink for new IGListArrayUtilsInternal.m
#1591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TimOliver has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@TimOliver merged this pull request in 2644442. |
GreeMoz
pushed a commit
to appintheair/IGListKit
that referenced
this pull request
Jan 31, 2024
Summary: ## Changes in this pull request I moved the functions from ` IGListArrayUtilsInternal.h` to `IGListArrayUtilsInternal.m` to ensure the code was properly captured for code coverage, but I forgot to re-run the SPM script to generate a new symlink for it. This should fix the failing sample app build tests. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: Instagram#1591 Test Plan: Confirmed this lets the sample apps run again. Reviewed By: fabiomassimo Differential Revision: D50013194 Pulled By: TimOliver fbshipit-source-id: ff4bebae781ebb460915458848cb340a89401a83
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
I moved the functions from
IGListArrayUtilsInternal.htoIGListArrayUtilsInternal.mto ensure the code was properly captured for code coverage, but I forgot to re-run the SPM script to generate a new symlink for it. This should fix the failing sample app build tests.Checklist
CHANGELOG.mdfor any breaking changes, enhancements, or bug fixes.