Codegen visitor functions #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Closed
rayjzeng
approved these changes
Aug 14, 2019
jimmylai
suggested changes
Aug 14, 2019
jimmylai
reviewed
Aug 21, 2019
jimmylai
reviewed
Aug 21, 2019
jimmylai
reviewed
Aug 21, 2019
added 5 commits
August 27, 2019 14:02
…sitor. This allows Pyre to typecheck returns inside visitors for us.
We want to make sure that the generated function stubs stay in sync with the node definitions. So, make a unit test that fails if codegen generates a different file than the existing file, so that somebody modifying code knows they need to re-run codegen.
Adds a BaseStatement type which can be used to specify in types that you can accept either a compound statement or a simple statement line.
There are a lot of nodes that cannot be removed or converted to maybes, such as most of the Op tokens. It would be a bit of a lie to codegen leave_* methods that allow these nodes to be converted, only to throw a runtime error later. So, upgrade the codegen to allow us to see whether certain nodes are used in conjunction with a MaybeSentinel/None, or inside a Sequence, to inform ourselves as to when to allow MaybeSentinel or RemovalSentinel.
|
I updated based on comments on PR #27 (a review of this code was mistakenly placed there) and added a bit more logic to generate better types. We have a BaseStatement now, and codegen can take into account the way nodes are used to correctly decide when to allow a MaybeSentinel or RemovalSentinel in a leave_* return. I don't think this is perfect, but if we run into cases that are wrong we can open up an issue and fix it. Having tighter types is more important IMO. |
jimmylai
reviewed
Aug 27, 2019
jimmylai
reviewed
Aug 28, 2019
jimmylai
reviewed
Aug 28, 2019
jimmylai
approved these changes
Aug 28, 2019
jimmylai
reviewed
Aug 28, 2019
|
Merged with stacked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement codegen for visit_* and leave_* methods so that pyre can warn about incorrect overloads and incorrect types. This includes code which does the actual codegen, a test that verifies that the codegen isn't out of date with the LibCST repo, and a tox environment/helper script for performing the codegen in a roughly atomic manner.
Test Plan
tox, as well as creating scenarios that 1) caused codegen failure to verify that we do the right thing when failing to codegen and 2) make us need a codegen, thus triggering a test failure.