Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: spaces around walrus operator #368

Merged
merged 1 commit into from
Aug 12, 2020
Merged

fix: spaces around walrus operator #368

merged 1 commit into from
Aug 12, 2020

Conversation

sk-
Copy link
Contributor

@sk- sk- commented Aug 12, 2020

Summary

Spaces around walrus operator are not required. Fixes #367

Test Plan

Unit test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 12, 2020
zsol
zsol approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@zsol zsol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@zsol zsol merged commit b4e04ea into Instagram:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsol zsol zsol approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cannot parse walrus operator without spaces around it
3 participants
@sk- @zsol @facebook-github-bot