Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum rust toolchain version #614

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Conversation

zsol
Copy link
Member

@zsol zsol commented Jan 18, 2022

In #613 people reported being unable to compile LibCST on rustc 1.52.1. This PR specifices the minimum version required to compile LibCST.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #614 (0180e50) into main (0c509b3) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 0180e50 differs from pull request most recent head af297ac. Consider uploading reports for the commit af297ac to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   94.77%   94.78%           
=======================================
  Files         245      245           
  Lines       25140    25238   +98     
=======================================
+ Hits        23826    23921   +95     
- Misses       1314     1317    +3     
Impacted Files Coverage Δ
libcst/codemod/commands/convert_type_comments.py 95.28% <0.00%> (+0.58%) ⬆️
...demod/commands/tests/test_convert_type_comments.py 96.72% <0.00%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c509b3...af297ac. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants