Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setuptools-rust to build requirements in setup.py #873

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

amyreese
Copy link
Member

Summary

Hoping this resolves the CI failures on 3.11

Test Plan

CI

Hoping this resolves the CI failures on 3.11
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 94.79% // Head: 94.79% // No change to project coverage 👍

Coverage data is based on head (f59b8b9) compared to base (8aebbb6).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files         249      249           
  Lines       25831    25831           
=======================================
  Hits        24487    24487           
  Misses       1344     1344           
Impacted Files Coverage Δ
setup.py 88.88% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amyreese amyreese merged commit 944ff15 into Instagram:main Feb 22, 2023
@amyreese amyreese deleted the rust branch February 22, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants