refactor: use static dispatch instead of dynamic dispatch #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
commented
Dec 31, 2023
| @@ -22,9 +23,8 @@ fn run_success() { | |||
| .split_whitespace(); | |||
|
|
|||
| let mut output_cursor = Cursor::new(vec![]); | |||
| let output_writer: &mut (dyn Write) = &mut output_cursor; | |||
There was a problem hiding this comment.
Yay! I don't have to use this ugly conversion any more 🎉
Integralist
commented
Dec 31, 2023
| @@ -7,14 +7,14 @@ use reqwest::StatusCode; | |||
| use std::collections::BTreeMap; | |||
| use std::io::{BufWriter, Write}; | |||
|
|
|||
| pub struct Headers<'a, 'b> { | |||
| pub struct Headers<'a, 'b, W: Write> { | |||
There was a problem hiding this comment.
Interestingly I didn't HAVE to assign a trait bound here.
I'm presuming the compiler was able to figure that out from the below impl block which does use a trait bound (at the compiler's request).
That said, I decided to be explicit about the trait bound here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why I thought I needed dynamic dispatch for this particular example.