This repository has been archived by the owner on Dec 11, 2022. It is now read-only.
Correct error type + order + error text #460
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see 2 issues with the ObservationStackingFilter object.
The current implementation checks that the input is less than 0, then checks that the input is a number. But if it's not a number, the checks that it is a number will never run. So when this check needs to be failed, the code has already failed earlier on, making it pointless.
Swapping the order fixes this. This should also be a TypeError, not a ValueError.
Secondly, there is no valid case for stacking 0 or 1 frames, so the code should assert >= 2, not >0