Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Enable running ActivationStatsCollector on post-train quantized models #419

Merged
merged 4 commits into from
Nov 13, 2019

Conversation

guyjacob
Copy link
Contributor

@guyjacob guyjacob commented Nov 6, 2019

No description provided.

Calling the module with .forward() instead of directly via the
object bypasses the hooks mechanism, which prevented flows like
stats and histogram collection from working on quantized models
Copy link
Contributor

@nzmora nzmora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look fine but I have one code suggestion, and a fix to one comment.

distiller/data_loggers/collector.py Outdated Show resolved Hide resolved
distiller/data_loggers/collector.py Outdated Show resolved Hide resolved
distiller/data_loggers/collector.py Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants