SAM Callback Update - Check If Optimizer Is Utilized #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laserkelvin
approved these changes
Apr 19, 2024
matsciml/lightning/callbacks.py
Outdated
| @@ -773,25 +773,42 @@ def extract_optimizer_specific_loss(self, task, optimizer, loss): | |||
| loss = loss[key] | |||
| return loss | |||
|
|
|||
| def is_optimizer_used(self, task, optimizer): | |||
| # Check if only one optimizer is used (singel task) | |||
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #188 where some optimizers parameter gradients would be
Nonedue to the optimizer not being used. This is due to each batch of data not necessarily containing data that will be used for each output head. A check is put in place to see if the current optimizer is used by checking what datasets are present in the current batch. If the optimizer is used then SAM runs as normal, otherwise SAM is skipped.