Relative spawn #87
Merged
Relative spawn #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Postolache <george.postolache@intel.com>
updated setup.py to get OdometryDistanceTraveled from differential_drive_robot.odometry_distance_traveled updated differential_drive_robot.odometry_distance_traveled to use namespace_override instead of namespace updated some feedback_messages from OdometryDistanceTraveled to convert self.distance_expected to float since sometimes it is not float initialised self.distance_traveled with 0.0 instead of 0. Signed-off-by: George Postolache <george.postolache@intel.com>
Signed-off-by: George Postolache <george.postolache@intel.com>
Test Results196 tests 182 ✅ 19m 16s ⏱️ Results for commit 7320fbb. ♻️ This comment has been updated with latest results. |
Scenario Results9 tests 9 ✅ 24m 29s ⏱️ Results for commit 4138e05. ♻️ This comment has been updated with latest results. |
use the external random method to use a random distance in the example scenario
fred-labs
requested changes
Jun 20, 2024
examples/example_simulation/scenarios/example_simulation_relative_spawn.osc
Outdated
Show resolved
Hide resolved
scenario_execution_gazebo/scenario_execution_gazebo/lib_osc/gazebo.osc
Outdated
Show resolved
Hide resolved
scenario_execution_gazebo/scenario_execution_gazebo/lib_osc/gazebo.osc
Outdated
Show resolved
Hide resolved
scenario_execution_ros/scenario_execution_ros/actions/odometry_distance_traveled.py
Show resolved
Hide resolved
simulation/gazebo/test_scenario_execution_gazebo/scenarios/test_relative_spawn.osc
Outdated
Show resolved
Hide resolved
fred-labs
approved these changes
Jun 21, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added action for spawning an object in front of a given tf frame in gazebo, supersedes #86
Pull request checklist
make check) pass locallyPull request type
Current behavior
no action to spawn an object relative to a given tf-frame
New behavior
action created for spawning an object relative to a given tf-frame
How to test