Modify building daal4py for wheel packages #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pahandrovich
force-pushed
the
dev/pyakovle-fix-path-win
branch
from
eb8c51e to
392dfd3
Compare
Pahandrovich
changed the title
Pahandrovich
force-pushed
the
dev/pyakovle-fix-path-win
branch
from
69f74eb to
9daf339
Compare
requirements-dev.txt
Outdated
| clang-format==9.0.0 | ||
| Cython==0.29.21 | ||
| Jinja2==2.11.3 | ||
| numpy>=1.18 |
PetrovKP
reviewed
Feb 4, 2021
requirements.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| dpcpp_cpp_rt==2021.1 | |||
| daal==2021.1 | |||
| numpy==1.20 | |||
There was a problem hiding this comment.
Users can use numpy less:
Suggested change
| numpy==1.20 | |
| numpy>=1.15 |
setup.py
Outdated
| author="Intel", | ||
| version=d4p_version, | ||
| url='https://github.com/IntelPython/daal4py', | ||
| author_email="onedal.maintainers@intel.com", |
There was a problem hiding this comment.
Need to align with current attributes
| setup_requires = [] | ||
| with open('requirements-dev.txt') as f: | ||
| setup_requires.extend(f.read().splitlines()) | ||
|
|
||
| # daal setup | ||
| setup(name="daal4py", |
There was a problem hiding this comment.
I would like see a result to tets.pypi
Pahandrovich
force-pushed
the
dev/pyakovle-fix-path-win
branch
2 times, most recently
from
bc03dd1 to
50cf5ea
Compare
Pahandrovich
force-pushed
the
dev/pyakovle-fix-path-win
branch
from
a1524d6 to
e239720
Compare
PetrovKP
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Daal4py from pip, without conda environment can't search onedal dll libraries. This changes needed to fix this problem.