This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
Add 2 benchmarks based on Pandas ones #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabled Airspeed Velocity benchmarks based on Pandas ones.
densmirn
requested review from
akharche,
Alexander-Makaryev,
AlexanderKalistratov,
kozlov-alexey,
shssf and
Vyacheslav-Smirnov
shssf
suggested changes
Aug 13, 2019
There was a problem hiding this comment.
Partially looked into these proposed changes.
I have no success in observing results by http://127.0.0.1:8080.
So, currently I could share first feelings only:
- Please move main
asv_benchdirectory intothird_partysubdirectory (create it). - Please keep all autogenerated data in
builddirectory (I see 3GB in asv_bench after procedure described in README.md) - Need to use less dependency for this. I mean, to get benchmark results you have to use web-browser (could not be existed in the system or misconfigured or something else). It is better to use simple text output.
- on WIndows I got strange errors during procedure. Should It works on Windows (Mac)?
Move benchmarks from asv_bench/ to benchmarks/asv_bench. Changed paths to ASV environment and benchmarks results from asv_bench/.asv to build/asv_bench/.asv Added extra information to README.md
shssf
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided benchmarking approach based on Pandas one.