Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

Conversation

rdesai16
Copy link
Contributor

This PR adds updated sphinx setup to enable automated documentation

@fschlimb
Copy link
Contributor

We need a way to view the result before accepting/merging, not only the sources. Any idea?

@shssf shssf added [WIP] Work in progress Documentation Label attached if some documentation strings added/changed labels Aug 30, 2019
@rdesai16
Copy link
Contributor Author

@fschlimb I am not sure how to do that. Maybe downloading these specific changes from my branch can help. But I will try to find another way and will keep you posted.

@shssf shssf changed the title [WIP]rearranged documentation rearranged documentation Sep 12, 2019
Copy link
Contributor

@fschlimb fschlimb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we want the pdf in the repository. It will quickly inflate the repository size.
This was just a quick review. We should update our docu asap.


conda create -n HPAT -c ehsantn -c numba/label/dev -c anaconda -c conda-forge hpat

Building from Source on Linux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to avoid duplication of build instructions. Building HPAT from sources should be the exception. Hence I'd prefer this to be in the README on github. The instructions in #142 have been verified.

Automatic Parallelization
-------------------------

HPAT parallelizes programs automatically based on the `map-reduce` parallel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HPAT is not only map-reduce. It can also do join, groupby etc which are more than that.
It uses domain-knowledge (pandas-like data analysis) to efficiently map the computation to distributed memory.

File I/O
--------

Currently, HPAT supports I/O for the `HDF5 <http://www.h5py.org/>`_ and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we currently do not support hdf5 anymore.

one processor only since all processors have the same copy.


Strings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string support has been 'moved' to numba.


#autosummary_generate = True
autosectionlabel_prefix_document = True
autodoc_mock_imports = ['numba',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no longer sure if autodoc is the right tool for user documentation. I currently do not see how it can help us providing the information we want to give to the user.
It remains to be seens if autodoc can be used for internaal developer docs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autodoc is useful if we have standardized docstrings inside our code to document the functions. In that case we can use it for both users guide and developers guide. Users will have information on how to use the functions and arguments whereas developers will have information on how to change the functions. So in current PR it is just used for distributed.py module as an example but I am working on using it for other modules.

@@ -22,10 +23,11 @@ regression program using HPAT::
w -= np.dot(z, X)
return w

This code runs on cluster and cloud environments using a simple command like
`mpiexec -n 1024 python logistic_regression.py`.
This code runs on cluster and cloud environments using a simple command like::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot is not the one use case we want to show in a quick intro. it should be something in pandas.

@rdesai16
Copy link
Contributor Author

I will soon submit new changes in this PR which has a different arrangement of the content and that is better than the one currently shown in this PR. @fschlimb thank you for your comments and they are very helpful. Once this PR is merged than we all can work together to make changes in the content inside every section.

@shssf
Copy link
Contributor

shssf commented Sep 12, 2019

@rdesai16 Is this PR ready to merge?

@rdesai16
Copy link
Contributor Author

@shssf Yes it is

@shssf shssf merged commit ad4eeda into IntelPython:master Sep 13, 2019
kozlov-alexey pushed a commit to kozlov-alexey/sdc that referenced this pull request Oct 4, 2019
* rearranged documentation

* further changes to rearrange the documentation

* rearranging and renaming some sections
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Label attached if some documentation strings added/changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants