Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up starlight usage #2029

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Clean up starlight usage #2029

merged 1 commit into from
Dec 4, 2022

Conversation

SirYwell
Copy link
Member

Overview

Description

Before Tuinity was integrated into Paper, we had to look up the starlight relight method dynamically.
Tuinity was merged during the 1.17.1 time, so I excluded the 1.17 adapter from the changes

Submitter Checklist

  • Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
  • Ensure that the pull request title represents the desired changelog entry.
  • New public fields and methods are annotated with @since TODO.
  • I read and followed the contribution guidelines.

@SirYwell SirYwell requested a review from a team as a code owner November 30, 2022 15:11
@github-actions github-actions bot added the chore label Nov 30, 2022
NotMyFault
NotMyFault approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@NotMyFault NotMyFault requested a review from a team December 1, 2022 22:01
yannicklamprecht
yannicklamprecht approved these changes Dec 2, 2022
View reviewed changes
Copy link

@yannicklamprecht yannicklamprecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotMyFault NotMyFault merged commit 79c23e0 into main Dec 4, 2022
@NotMyFault NotMyFault deleted the refactor/cleanup-starlight-relighter branch December 4, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannicklamprecht yannicklamprecht yannicklamprecht approved these changes

@dordsor21 dordsor21 dordsor21 approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@PierreSchwang PierreSchwang PierreSchwang approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SirYwell @yannicklamprecht @dordsor21 @NotMyFault @PierreSchwang