feat: improvements to clipboard on disk #2162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dordsor21
commented
Mar 25, 2023
•
dordsor21
commented
- close clipboard on instantiation failure
- set canHaveBiomes when loading clipboard from disk (only possible cause I can find for Size exceeds Integer.MAX_VALUE on clipboard on disk load #2151 ..?)
- check file length and give more appropriate error if it exceeds maximum. Fixes Size exceeds Integer.MAX_VALUE on clipboard on disk load #2151 I guess?
- set byteBuffer to null before invoking cleaning. Fixes FAWE crashes JVM on huge schematic pasting and executor player leaving #1985
- close clipboard on instantiation failure - set canHaveBiomes when loading clipboard from disk (only possible cause I can find for #2151 ..?) - check file length and give more appropriate error if it exceeds maximum. Fixes #2151 I guess?# - set byteBuffer to null before invoking cleaning. Addresses #1985 - don't catch and print all exceptions when getBlock fails - prevents large console output for what is likely to be a failed operation anyway
dordsor21
force-pushed
the
feature/disk-clipboard-safety-improvements
branch
from
3d4522c
to
d3d1212
Compare
SirYwell
requested changes
Mar 25, 2023
...-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/DiskOptimizedClipboard.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/fastasyncworldedit/core/extent/clipboard/DiskOptimizedClipboard.java
Outdated
Show resolved
Hide resolved
SirYwell
approved these changes
Mar 26, 2023
NotMyFault
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.